From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 73046@debbugs.gnu.org
Subject: bug#73046: 29.4; Emacs 100% CPU usage for several seconds when opening dired buffer over TRAMP
Date: Sun, 08 Sep 2024 13:26:02 +0200 [thread overview]
Message-ID: <87wmjmidyt.fsf@gmx.de> (raw)
In-Reply-To: <87plpf2vnx.fsf@gmail.com> (Suhail Singh's message of "Sat, 07 Sep 2024 13:58:10 -0400")
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
Suhail Singh <suhailsingh247@gmail.com> writes:
Hi Suhail,
>> There's a new user option `dired-highlight-symlinks'. If non-nil (the
>> default), symlinks are highlighted the same way as now. With a nil
>> value, they aren't.
>
> I propose that the non-default behaviour be that `dired-symlink-face' is
> applied to the entirety of the symlink. If you agree, it might be
> better to additionally rename `dired-highlight-symlinks' accordingly to
> reflect the updated behaviour.
Good catch, see reworked patch below. The user option has been renamed
to dired-check-symlinks.
> TIL about connection-local variables. Yes, this would be helpful.
> However, if so desired, I imagine that setting
> `dired-highlight-symlinks' buffer-locally in the `dired-mode-hook' would
> work as well. Is my understanding correct?
Yes, connection-local variables are implemented as buffer-local
variables.
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 3575 bytes --]
diff --git a/lisp/dired.el b/lisp/dired.el
index 0d526dfc376..bc984c3506d 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -738,6 +738,13 @@ dired-ignored-face
\f
;;; Font-lock
+(defcustom dired-check-symlinks t
+ "Whether symlinks are checked for validity.
+Set it to nil for remote directories, which suffer from a slow connection."
+ :type 'boolean
+ :group 'dired
+ :version "31.1")
+
(defvar dired-font-lock-keywords
(list
;;
@@ -815,11 +822,13 @@ dired-font-lock-keywords
;; Broken Symbolic link.
(list dired-re-sym
(list (lambda (end)
- (let* ((file (dired-file-name-at-point))
- (truename (ignore-errors (file-truename file))))
- ;; either not existent target or circular link
- (and (not (and truename (file-exists-p truename)))
- (search-forward-regexp "\\(.+\\) \\(->\\) ?\\(.+\\)" end t))))
+ (when (connection-local-value dired-check-symlinks)
+ (let* ((file (dired-file-name-at-point))
+ (truename (ignore-errors (file-truename file))))
+ ;; either not existent target or circular link
+ (and (not (and truename (file-exists-p truename)))
+ (search-forward-regexp
+ "\\(.+\\) \\(->\\) ?\\(.+\\)" end t)))))
'(dired-move-to-filename)
nil
'(1 'dired-broken-symlink)
@@ -829,10 +838,12 @@ dired-font-lock-keywords
;; Symbolic link to a directory.
(list dired-re-sym
(list (lambda (end)
- (when-let* ((file (dired-file-name-at-point))
- (truename (ignore-errors (file-truename file))))
- (and (file-directory-p truename)
- (search-forward-regexp "\\(.+-> ?\\)\\(.+\\)" end t))))
+ (when (connection-local-value dired-check-symlinks)
+ (when-let* ((file (dired-file-name-at-point))
+ (truename (ignore-errors (file-truename file))))
+ (and (file-directory-p truename)
+ (search-forward-regexp
+ "\\(.+-> ?\\)\\(.+\\)" end t)))))
'(dired-move-to-filename)
nil
'(1 dired-symlink-face)
@@ -841,12 +852,15 @@ dired-font-lock-keywords
;; Symbolic link to a non-directory.
(list dired-re-sym
(list (lambda (end)
- (when-let ((file (dired-file-name-at-point)))
- (let ((truename (ignore-errors (file-truename file))))
- (and (or (not truename)
- (not (file-directory-p truename)))
- (search-forward-regexp "\\(.+-> ?\\)\\(.+\\)"
- end t)))))
+ (if (not (connection-local-value dired-check-symlinks))
+ (search-forward-regexp
+ "\\(.+-> ?\\)\\(.+\\)" end t)
+ (when-let ((file (dired-file-name-at-point)))
+ (let ((truename (ignore-errors (file-truename file))))
+ (and (or (not truename)
+ (not (file-directory-p truename)))
+ (search-forward-regexp
+ "\\(.+-> ?\\)\\(.+\\)" end t))))))
'(dired-move-to-filename)
nil
'(1 dired-symlink-face)
next prev parent reply other threads:[~2024-09-08 11:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 14:24 bug#73046: 29.4; Emacs 100% CPU usage for several seconds when opening dired buffer over TRAMP Suhail Singh
2024-09-05 15:56 ` Eli Zaretskii
2024-09-05 21:04 ` Suhail Singh
2024-09-06 5:40 ` Eli Zaretskii
2024-09-06 13:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-06 13:54 ` Eli Zaretskii
2024-09-06 14:09 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-06 16:09 ` Eli Zaretskii
2024-09-06 17:47 ` Suhail Singh
2024-09-06 19:08 ` Eli Zaretskii
2024-09-07 0:19 ` Suhail Singh
2024-09-07 1:39 ` Suhail Singh
2024-09-07 6:29 ` Eli Zaretskii
2024-09-07 8:07 ` Suhail Singh
2024-09-07 14:36 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-07 15:07 ` Eli Zaretskii
2024-09-07 17:35 ` Suhail Singh
2024-09-08 11:30 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 11:47 ` Eli Zaretskii
2024-09-08 15:26 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 15:41 ` Eli Zaretskii
2024-09-08 16:46 ` Suhail Singh
2024-09-08 17:53 ` Eli Zaretskii
2024-09-10 8:10 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 1:05 ` Suhail Singh
2024-09-11 11:50 ` Eli Zaretskii
2024-09-11 16:29 ` Suhail Singh
2024-09-11 16:38 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 17:25 ` Suhail Singh
2024-09-12 11:48 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 14:13 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 15:56 ` Suhail Singh
2024-09-13 23:17 ` Suhail Singh
2024-09-14 6:24 ` Eli Zaretskii
2024-09-14 14:25 ` Suhail Singh
2024-09-14 14:41 ` Suhail Singh
2024-09-14 15:03 ` Eli Zaretskii
2024-09-14 22:36 ` Suhail Singh
2024-09-15 5:55 ` Eli Zaretskii
2024-09-15 14:23 ` Suhail Singh
2024-09-14 7:07 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 14:39 ` Suhail Singh
2024-09-11 14:06 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-07 14:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-07 17:58 ` Suhail Singh
2024-09-08 11:26 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-08 15:09 ` Suhail Singh
2024-09-08 15:19 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-08 15:34 ` Suhail Singh
2024-09-08 16:35 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 16:19 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-06 16:56 ` Suhail Singh
2024-09-06 16:01 ` Suhail Singh
2024-09-06 15:46 ` Suhail Singh
2024-09-06 15:52 ` Suhail Singh
[not found] <87v7yz1sw8.fsf@rutgers.edu>
2024-09-13 15:47 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmjmidyt.fsf@gmx.de \
--to=bug-gnu-emacs@gnu.org \
--cc=73046@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=suhailsingh247@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).