From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Tue, 01 Oct 2024 09:01:19 +0800 Message-ID: <87wmisprfk.fsf@melete.silentflame.com> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> <878qv9scps.fsf@melete.silentflame.com> <12b28146-5cbc-48cd-b0e2-0c528d4b9b1c@yandex.ru> <87ikudqocz.fsf@melete.silentflame.com> <9be40a05-3260-40a8-9c35-c5daac413844@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 01 03:02:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svRHz-000765-0r for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Oct 2024 03:02:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svRHa-0005gT-Az; Mon, 30 Sep 2024 21:02:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svRHY-0005gE-QZ for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:02:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svRHY-0004GZ-G8 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:02:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=fguWiSL/bQCamOkBKIAY8KJKOBmLQO5tv4qlT+xi1+I=; b=T4Su2UemzcIRPwkRrPisUTy6N4PosRYLRbss086J9Ae546xRMidiKKBhZ2NDe2ULdBs9/5NxtT1Qy1NHeJbE3cINcx7XjYV1yoYjivJN7+RqVUquT44L+tZeCakB+O8Hj5Okt12X8XCIIvShbLg1+ph2oCzhQ4OzsCGYCmZnIUTQ55O9OiAEZDwzi84I0sa6GwIjbPwMl5wrq6N6hknyVYI/HldFA9dJ43GQ8Em/E7lA4mhUtTfsU4Ls5wEJLKotpu3sgrI7N5NFom2ejCWO0TH75XfSxrS7SnWLBhK+m94/KzXG3HP5nfwk3H5C4L20neaixWUN8hy//0nhI2scBw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svRI5-0000iX-Lm for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2024 01:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.17277445252714 (code B ref 73387); Tue, 01 Oct 2024 01:03:01 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 1 Oct 2024 01:02:05 +0000 Original-Received: from localhost ([127.0.0.1]:48151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svRHA-0000hi-L9 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 21:02:04 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:55322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svRH7-0000hD-Ls for 73387@debbugs.gnu.org; Mon, 30 Sep 2024 21:02:02 -0400 DKIM-Signature: a=rsa-sha256; b=SHTYU5ZLkkwLcYzYOovDKtyvuv8RoxAVGLMhLXB6X4bGooWUrCh4I8jTOgKVzd+Iq2s97CBENCplYy3UdzZXWaVahJ1h438a+vxSBBuU3gH3b6oZ6GTx7hXzx2Xw3V9/5L2bz2wEPnKKK1gZECckA9gruPkl1GHJWfk+XtFPrVEH5qYe1DQsUAxobSvE6LTRgs1rwBu1MItqxbQ9hpFOxGKox487oZo2pMhcTGES87Ol1UfFGoROGRAqapS4CFfYcKyAOT9f9CoVHouge6KWGmm1GCar27YxAJgJYzl6UzXZl5yWxIN3JvQRmFR0x7bbRfWRdDCVqYpzuWueCsKYsw==; s=purelymail2; d=spwhitton.name; v=1; bh=9kz0+2WgakRDYoOfmUwAyu4Ky/+eXpoiDk9JelgxzGM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=iGZV2R6J8iFbVSUGM6pKSG+ocaymxOibsMYhA6mjT5ZdBGF/+Si/0qt+CL4GVWcjSXneB96273HYP9M1HgXNz9GkQtJnN13bHwUv1MkxFkzEzm+zqK7FUhiEKIkkNUMumLyUbj/RyoLFpBfjRpUTKOLK0duYtvvLZKZAdm0dl2Sb3lMSIkP8I55FzwDXm6H3D0JhLhP1JFiu5ByfvbVkFpFFTgGtqG/aZznQ0qlBmmwD7JoS+gHQBB37ZNnz3gvlDNv13o2OW/9BesrWMPyiHWhcfT9ErSPcTSSUESt7mAoNNdkpwYxaLlKLZJ//y2D2D1SdhIzJx3AB73Fzujm9DA==; s=purelymail2; d=purelymail.com; v=1; bh=9kz0+2WgakRDYoOfmUwAyu4Ky/+eXpoiDk9JelgxzGM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73387@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -362506431; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 01 Oct 2024 01:01:21 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 3124F7E1AB0; Tue, 1 Oct 2024 02:01:19 +0100 (BST) In-Reply-To: <9be40a05-3260-40a8-9c35-c5daac413844@yandex.ru> (Dmitry Gutov's message of "Tue, 1 Oct 2024 03:39:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292752 Archived-At: Hello, On Tue 01 Oct 2024 at 03:39am +03, Dmitry Gutov wrote: > On 30/09/2024 16:10, Sean Whitton wrote: >> I tested the (apply #'user-error ...) by applying your patch from >> up-thread, though I think there may be a bug with that patch because >> after applying it I was not able to use C-x v v to commit. >> (FTAOD I think the attached is valid independently of your patch.) > > That patch was an illustration to answer the direct question (how to make > diff-file-next work in narrowed buffer), but indeed - like mentioned in the > same message - it didn't help on the next step. > > So I'm not proposing it for inclusion, your patch should very well work on its > own. I don't think that's quite right. If you use C-c C-n in a diff-mode buffer with current master, then C-x v v doesn't get far enough to call the user-error I added. "No next file" is not the error message that you should get. -- Sean Whitton