From: Protesilaos Stavrou <info@protesilaos.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 74104@debbugs.gnu.org
Subject: bug#74104: 31.0.50; 'custom-set-faces' overrides face when no theme is loaded
Date: Thu, 31 Oct 2024 07:35:34 +0200 [thread overview]
Message-ID: <87wmhozvfd.fsf@protesilaos.com> (raw)
In-Reply-To: <86plnh4n2l.fsf@gnu.org>
> From: Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 30 Oct 2024 17:39:30 +0200
>
>> From: Protesilaos Stavrou <info@protesilaos.com>
>> Date: Wed, 30 Oct 2024 12:14:40 +0200
>>
>> Dear maintainers,
>>
>> When a theme is already enabled, 'custom-set-faces' has the effect of
>> adding face attributes on top of the existing ones. Those that were
>> present are not removed: they are blended with the new ones.
>>
>> This, however, is not happening when no theme is loaded. In that
>> scenario, 'custom-set-faces' removes all the underlying face attributes
>> and keeps only those specified in the function call. I think this is a
>> mistake.
>
> custom-set-faces is used to set up customized faces in the user's init
> files: they are the forms written by Custom when the user decides to
> save the face customizations for future sessions. So I don't think
> this is a mistake, and I don't see how we can change this without
> catastrophic effects on everyone's init files.
Indeed, I do not want to break anybody's setup or even make far-reaching
changes just for this. Do you think the difference in behaviour when a
theme is loaded versus when it is not is the intended design?
--
Protesilaos Stavrou
https://protesilaos.com
prev parent reply other threads:[~2024-10-31 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 10:14 bug#74104: 31.0.50; 'custom-set-faces' overrides face when no theme is loaded Protesilaos Stavrou
2024-10-30 15:39 ` Eli Zaretskii
2024-10-31 5:35 ` Protesilaos Stavrou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmhozvfd.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=74104@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).