From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74775: [PATCH] Update browse-url-kde variables Date: Wed, 11 Dec 2024 19:41:32 +0200 Message-ID: <87wmg6ce2b.fsf@thaodan.de> References: <86jzc64cod.fsf@gnu.org> <87cyhyuxjh.fsf@thaodan.de> <86ttba2o4e.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74775@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 18:42:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLQj8-0005RN-JY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 18:42:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLQiq-0002DS-3V; Wed, 11 Dec 2024 12:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLQio-0002Cp-Hi for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 12:42:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLQio-0002l1-9D for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 12:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=iFaF5TLYpgmxWabzUP+DPMspLEgKaFZuIl0NUXSJ/aw=; b=KhYpyfgLlJnkF80h1ADObPDNRJTyAR6j0mJQvTm1O6okHrw0ZRSzu/qltIChPNu0LJOG1IWlT9YTHTOSvIrhYgtS6lrrEuY9PMMofE72Xb6uGeJre6f5S+5vJOs3gKliHVt3noWyIFBlcy4hbcCvHsgw/Lub/G/zL8csvfs7Xmn22yQfPZuN7yuixoEnH6KjfHYbpde57HiyArqCwXjndjm9J5EUBExemeBDZ+CrT32AR/+sYcCj2MNbiCZHMWzOlbyYaMGBSnfx/NutcGhnXkd26QpPem9IyVHU02WCe7KoB5WvvJiQzcU2viItJmFOr3K81K58X40plWap4H4AKQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLQin-0000kZ-UR for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 12:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74775 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74775-submit@debbugs.gnu.org id=B74775.17339389002843 (code B ref 74775); Wed, 11 Dec 2024 17:42:01 +0000 Original-Received: (at 74775) by debbugs.gnu.org; 11 Dec 2024 17:41:40 +0000 Original-Received: from localhost ([127.0.0.1]:36152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLQiS-0000jn-Cf for submit@debbugs.gnu.org; Wed, 11 Dec 2024 12:41:40 -0500 Original-Received: from thaodan.de ([185.216.177.71]:49406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLQiO-0000ja-Ql for 74775@debbugs.gnu.org; Wed, 11 Dec 2024 12:41:38 -0500 Original-Received: from NordStern (unknown [185.252.118.71]) by thaodan.de (Postfix) with ESMTPSA id D98C6D00059; Wed, 11 Dec 2024 19:41:33 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733938894; bh=NnH2UgWqwh9HhLpPNO1tvmZJeq+moPzros7ADF4p7ZA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=XxXh+d9EfjwtQKOzUpdRmnsoddejd+J+DvCMmrhF0yp9qq/uiVzXjcrqx4vMSkzKE QHQ2tFMiTSVlYoFQXu5/dm8/NKc+BPlVRJti0Ju6HhmdlMLVPzaKvaEyOYxEy1wFHo XHRRWfPCw9MAv6D76vV/8QO0lda4087JUwlOFbO6+cs5PUgPUCSNJVCjJNvLtZlScE Tby5LDp7ZxmtCKJJMLX1k2O7PsEKff81jBLILlDBjChUWV1Y6gT1+bmwCDedcRyLTo qRpo6FAxvSH8ZOcFE9j5fyO9hPfc/zwEazz++U+aQFzXUdqFUrCDxoaBkxqrnAKdSa SAwQAAXRvz5iVOhrTY520USEl0OcLcLj/qWSvXzHjoZzcOwyjkeHz0WXdjmPffxBUm 0jdDYwTapyAoOHpFbUGFJcmsxKfGvCC4ONUu85KN5dZ7x4PPFynMMyzMvP5NMmuSaO 55ZUBjUTFkM1qsYSJnQHKkp9oi0nXnZTcjkCvuzHC+MtHnkitmcR/VlZY5Pjl+smy9 a9DVMvm6AH828KJsptYhuB/kz5kL06EU5sVdNdJ0yXX519Fe67JHiLtThjn6LbiGfC 0axIdWLwEUafU8wctO5YLwY8486LD54tVRK8q+ROtXE3LLZPEMhvyYjx77Qz74WnV6 MY50Mvr1t0M7KqbkB38Mqp/E= In-Reply-To: <86ttba2o4e.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Dec 2024 18:14:25 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296859 Archived-At: Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: 74775@debbugs.gnu.org >> Date: Wed, 11 Dec 2024 16:03:30 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> :type 'string >> > >> > Should this be 'file instead? >>=20 >> Does 'file for programs in path? > > No, but the user could enter an absolute file name here, in which case > 'file will be more useful. I think it's unlikely but possible sure. >> >> -(defcustom browse-url-kde-args '("openURL") >> >> +(defcustom browse-url-kde-args nil >> >> "A list of strings defining options for `browse-url-kde-program'." >> > >> > Should the default value depend on the value of >> > browse-url-kde-program? E.g., if that is customized to kfmclient, the >> > value of this variable should probably not be '("openURL"), right? >>=20 >> For kfmclient it should be '("openURL") for others not. >>=20 >> I think it would make sense to apply this change to Emacs 30 too as it >> isn't a functionality change but a fix to not use kfmclient which is not >> installed anymore these days as the default file manager for KDE is >> Dolphin and not Konqueror which includes kfmclient. > > I'd prefer not to change defaults in Emacs 30 at this point, but if > you think the current defaults might be not useful, then I'll ask in > what version(s) of current systems using KDE this change happened, and > how probable is it that users are still using those old versions? The change happened in KDE 4 which was released in 2008. The change would break users of KDE3 which isn't supported anymore since 15 years by now. So the change would fix the behavior of users which are still on KDE 4 or 5 (Technically KDE Plasma in this context after KDE3) and those which use the latest stable KDE Plasma 6. > Installing on master doesn't need to delve into these issues, since if > we are wrong, we have enough time for users to holler and for us to > fix. Emacs 30, OTOH, is very close to the release, so we must be very > certain this change cannot cause any trouble. I don't think there's a chance for that. If you decide to install the change on Emacs 30. Do you want me to send the patch again with the changes mentioned by you i.e. defcustom version and type?