From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: theo@thornhill.no, casouri@gmail.com, mickey@masteringemacs.org,
monnier@iro.umontreal.ca, 73404@debbugs.gnu.org
Subject: bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes
Date: Thu, 12 Dec 2024 18:31:04 +0200 [thread overview]
Message-ID: <87wmg53rdj.fsf@mail.linkov.net> (raw)
In-Reply-To: <87ldwl8g60.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 12 Dec 2024 10:14:59 +0200")
> A better idea: instead of 'sexp' in treesit-thing-settings
> define separately 'list' and 'atom', e.g. replace
>
> (setq-local treesit-thing-settings
> `((javascript
> (sexp ,(js--regexp-opt-symbol js--treesit-sexp-nodes)))))
>
> with
>
> (setq-local treesit-thing-settings
> `((javascript
> (list ,(js--regexp-opt-symbol js--treesit-list-nodes))
> (atom ,(js--regexp-opt-symbol js--treesit-atom-nodes)))))
Still the problem is that using the atoms from the tree
doesn't provide backward-compatibility with non-ts modes
and how C-M-f moves on non-list atoms there.
One way would be to extract anonymous text leaf nodes
such as "export" and "const" from
(export_statement "export" declaration:
(lexical_declaration kind: "const"
But still need to check symbol/word syntax to omit such nodes
as "+" from
(binary_expression left: (identifier) operator: "+"
Therefore to provide backward-compatibility with non-ts modes
in regard to C-M-f navigation, navigation on atoms should follow
the Sword/Ssymbol rules of 'scan_lists' with non-nil 'sexpflag'.
So an atom should be a syntactical entity, not structural.
This means that treesit-forward-sexp should use the 'list' thing
with syntactical atoms.
For example, for 'C-M-f' on
var p = {
case: 'zzzz',
-!-default: 'donkey',
tee: 'ornery'
};
in js-ts-mode it would be unexpected to move to
var p = {
case: 'zzzz',
default: 'donkey'-!-,
tee: 'ornery'
};
because js-mode moves to
var p = {
case: 'zzzz',
default-!-: 'donkey',
tee: 'ornery'
};
But anyway 'list' should be customizable as 'sexp' already is.
OTOH, transpose-sexps should use treesit 'sexp' with more fine-grained
lists that are not suitable for forward-sexp.
(And we have no transpose-lists.)
For example, it's expected for transpose-sexps to transpose
a pair of key:value defined by 'sexp':
var p = {
default: 'donkey',
-!-case: 'zzzz',
tee: 'ornery'
};
that will be a big improvement when comparing to js-mode.
This also will close bug#60655.
And if someone want to transpose adjacent atoms (symbols or words),
there is transpose-words.
In summary:
The current implementation in treesit-forward-sexp is more like forward-list.
So let's rename it to treesit-forward-list, then create a new implementation
of treesit-forward-sexp that uses the 'list' thing together with
syntactical atoms.
Another variant is to leave treesit-forward-sexp as is,
and create a new function treesit-forward-sexp-with-list
that uses the 'list' thing.
And anyway let's keep the current implementation
of treesit-transpose-sexps that uses the 'sexp' thing.
next prev parent reply other threads:[~2024-12-12 16:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 5:06 bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes Mickey Petersen
2024-09-26 7:42 ` Yuan Fu
2024-09-26 9:56 ` Mickey Petersen
2024-09-26 10:53 ` Eli Zaretskii
2024-09-26 12:13 ` Mickey Petersen
2024-09-26 13:46 ` Eli Zaretskii
2024-09-26 15:21 ` Mickey Petersen
2024-09-26 15:45 ` Eli Zaretskii
2024-09-27 5:43 ` Yuan Fu
2024-09-29 16:56 ` Juri Linkov
2024-10-01 3:57 ` Yuan Fu
2024-10-01 17:49 ` Juri Linkov
2024-10-02 6:14 ` Yuan Fu
2024-12-05 18:52 ` Juri Linkov
2024-12-05 19:53 ` Juri Linkov
2024-12-10 17:20 ` Juri Linkov
2024-12-11 6:31 ` Yuan Fu
2024-12-11 15:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 15:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 16:50 ` Mickey Petersen
2024-12-11 18:27 ` Yuan Fu
2024-12-12 7:17 ` Juri Linkov
2024-12-12 7:40 ` Eli Zaretskii
2024-12-12 7:58 ` Juri Linkov
2024-12-12 8:14 ` Juri Linkov
2024-12-12 16:31 ` Juri Linkov [this message]
2024-12-12 17:49 ` Juri Linkov
2024-12-12 19:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmg53rdj.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=73404@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=mickey@masteringemacs.org \
--cc=monnier@iro.umontreal.ca \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).