From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Dan Jacobson Newsgroups: gmane.emacs.bugs Subject: Re: View-scroll-page-forward baby steps not grown out of Date: Thu, 30 Sep 2004 05:03:26 +0800 Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: <87vfdwkctd.fsf@jidanni.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1096502105 21451 80.91.229.6 (29 Sep 2004 23:55:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 29 Sep 2004 23:55:05 +0000 (UTC) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 30 01:55:01 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CCoHl-0004ct-00 for ; Thu, 30 Sep 2004 01:55:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CCoO8-0005uF-0B for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Sep 2004 20:01:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CCoO2-0005sq-1D for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2004 20:01:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CCoO0-0005sB-T1 for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2004 20:01:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CCoO0-0005s6-P3 for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2004 20:01:28 -0400 Original-Received: from [204.74.68.40] (helo=frodo.hserus.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CCoHO-0008Mc-LO for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2004 19:54:38 -0400 Original-Received: from ppp-218-32-112-28.tc.sparqnet.net ([218.32.112.28]:32925 helo=jidanni1) by frodo.hserus.net with esmtpsa (Cipher TLSv1:RC4-SHA:128) (Exim 4.42 #0) id 1CCoHK-000N4b-S0 by authid with plain for ; Thu, 30 Sep 2004 05:24:37 +0530 Original-Received: from jidanni by jidanni1 with local (Exim 4.34) id 1CClbj-00011H-1a for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2004 05:03:27 +0800 Original-To: bug-gnu-emacs@gnu.org X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:9135 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:9135 --=-=-= RMS> Does this patch fix it? Probably, but on Debian we don't have as new an emacs to patch and test against. I'll post it so the pros can examine it. --=-=-= Content-Type: message/rfc822 Content-Disposition: inline *** view.el 13 Mar 2004 18: 57:29 -0500 1.75 --- view.el 29 Sep 2004 07: 13:22 -0400 *************** *** 117,128 **** (defvar view-page-size nil "Default number of lines to scroll by View page commands. ! If nil then the local value of this is initially set to window size.") (make-variable-buffer-local 'view-page-size) (defvar view-half-page-size nil "Default number of lines to scroll by View half page commands. ! If nil then the local value of this is initially set to half window size.") (make-variable-buffer-local 'view-half-page-size) (defvar view-last-regexp nil) --- 117,128 ---- (defvar view-page-size nil "Default number of lines to scroll by View page commands. ! If nil that means use the window size.") (make-variable-buffer-local 'view-page-size) (defvar view-half-page-size nil "Default number of lines to scroll by View half page commands. ! If nil that means use half the window size.") (make-variable-buffer-local 'view-half-page-size) (defvar view-last-regexp nil) *************** *** 453,460 **** ;; This is to guarantee that the buffer-read-only variable is restored. (add-hook 'change-major-mode-hook 'view-mode-disable nil t) (setq view-mode t ! view-page-size (view-page-size-default view-page-size) ! view-half-page-size (or view-half-page-size (/ (view-window-size) 2)) view-old-buffer-read-only buffer-read-only buffer-read-only t view-old-Helper-return-blurb (and (boundp 'Helper-return-blurb) --- 453,460 ---- ;; This is to guarantee that the buffer-read-only variable is restored. (add-hook 'change-major-mode-hook 'view-mode-disable nil t) (setq view-mode t ! view-page-size nil ! view-half-page-size nil view-old-buffer-read-only buffer-read-only buffer-read-only t view-old-Helper-return-blurb (and (boundp 'Helper-return-blurb) *************** *** 675,681 **** (defun view-set-half-page-size-default (lines) ;; Get and maybe set half page size. ! (if (not lines) view-half-page-size (setq view-half-page-size (if (zerop (setq lines (prefix-numeric-value lines))) (/ (view-window-size) 2) --- 675,682 ---- (defun view-set-half-page-size-default (lines) ;; Get and maybe set half page size. ! (if (not lines) (or view-half-page-size ! (/ (view-window-size) 2)) (setq view-half-page-size (if (zerop (setq lines (prefix-numeric-value lines))) (/ (view-window-size) 2) *************** *** 803,815 **** \\[View-scroll-page-backward-set-page-size]. If LINES is more than a window-full, only the last window-full is shown." (interactive "P") ! (view-scroll-lines lines nil view-page-size nil)) (defun View-scroll-page-backward (&optional lines) "Scroll \"page size\" or prefix LINES lines backward in View mode. See also `View-scroll-page-forward'." (interactive "P") ! (view-scroll-lines lines t view-page-size nil)) (defun View-scroll-page-forward-set-page-size (&optional lines) "Scroll forward LINES lines in View mode, setting the \"page size\". --- 804,816 ---- \\[View-scroll-page-backward-set-page-size]. If LINES is more than a window-full, only the last window-full is shown." (interactive "P") ! (view-scroll-lines lines nil (view-page-size-default view-page-size) nil)) (defun View-scroll-page-backward (&optional lines) "Scroll \"page size\" or prefix LINES lines backward in View mode. See also `View-scroll-page-forward'." (interactive "P") ! (view-scroll-lines lines t (view-page-size-default view-page-size) nil)) (defun View-scroll-page-forward-set-page-size (&optional lines) "Scroll forward LINES lines in View mode, setting the \"page size\". MIME-Version: 1.0 --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Bug-gnu-emacs mailing list Bug-gnu-emacs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs --=-=-=--