From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#179: 23.0.60; Menu separators are not displayed Date: Tue, 05 Aug 2008 17:54:49 -0400 Message-ID: <87vdyf86vq.fsf@stupidchicken.com> Reply-To: Chong Yidong , 179@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217974126 29420 80.91.229.12 (5 Aug 2008 22:08:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Aug 2008 22:08:46 +0000 (UTC) Cc: 179@emacsbugs.donarmstrong.com To: David Kastrup Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 06 00:09:37 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KQUig-0003Jv-Ay for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Aug 2008 00:09:30 +0200 Original-Received: from localhost ([127.0.0.1]:34185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQUhl-0001H0-4k for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Aug 2008 18:08:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQUgh-0000Ah-0A for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:07:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQUgf-00008z-Ua for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:07:26 -0400 Original-Received: from [199.232.76.173] (port=43795 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQUgf-00008c-N0 for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:07:25 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49414) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KQUge-0001SC-V6 for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2008 18:07:25 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m75M7M7i013363; Tue, 5 Aug 2008 15:07:23 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m75M04Cw008994; Tue, 5 Aug 2008 15:00:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 05 Aug 2008 22:00:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo patch Original-Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.12179732656699 (code B ref 179); Tue, 05 Aug 2008 22:00:04 +0000 Original-Received: (at 179) by emacsbugs.donarmstrong.com; 5 Aug 2008 21:54:25 +0000 Original-Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m75LsM0t006690 for <179@emacsbugs.donarmstrong.com>; Tue, 5 Aug 2008 14:54:23 -0700 Original-Received: by cyd (Postfix, from userid 1000) id 422DA57E338; Tue, 5 Aug 2008 17:54:49 -0400 (EDT) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Tue, 05 Aug 2008 18:07:26 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19047 Archived-At: Hello David, Did you ever get the chance to try Stefan's patch from May? Stefan Monnier wrote: > Does the patch below fix it? > > Stefan --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 +++ subr.el 2008-05-05 02:58:00.000000000 -0400 @@ -571,10 +571,14 @@ (let* ((key (car binding)) (item (cdr binding)) (oldbind (assq key bindings))) + (if (null key) + ;; nil keys are/were used by easy-menu for "separator lines and + ;; separator titles". Merging them makes no sense. + (push binding bindings) ;; Newer bindings override older. (if oldbind (setq bindings (delq oldbind bindings))) (when item ;nil bindings just hide older ones. - (push binding bindings)))) + (push binding bindings))))) (nconc map bindings))) (put 'keyboard-translate-table 'char-table-extra-slots 0)