From: Chong Yidong <cyd@stupidchicken.com>
To: David Kastrup <dak@gnu.org>
Cc: 179@emacsbugs.donarmstrong.com
Subject: bug#179: 23.0.60; Menu separators are not displayed
Date: Tue, 05 Aug 2008 17:54:49 -0400 [thread overview]
Message-ID: <87vdyf86vq.fsf@stupidchicken.com> (raw)
Hello David,
Did you ever get the chance to try Stefan's patch from May?
Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Does the patch below fix it?
>
> Stefan
--- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400
+++ subr.el 2008-05-05 02:58:00.000000000 -0400
@@ -571,10 +571,14 @@
(let* ((key (car binding))
(item (cdr binding))
(oldbind (assq key bindings)))
+ (if (null key)
+ ;; nil keys are/were used by easy-menu for "separator lines and
+ ;; separator titles". Merging them makes no sense.
+ (push binding bindings)
;; Newer bindings override older.
(if oldbind (setq bindings (delq oldbind bindings)))
(when item ;nil bindings just hide older ones.
- (push binding bindings))))
+ (push binding bindings)))))
(nconc map bindings)))
(put 'keyboard-translate-table 'char-table-extra-slots 0)
next reply other threads:[~2008-08-05 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 21:54 Chong Yidong [this message]
2008-08-05 22:10 ` bug#179: 23.0.60; Menu separators are not displayed David Kastrup
2008-08-08 18:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdyf86vq.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=179@emacsbugs.donarmstrong.com \
--cc=dak@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).