From: Chong Yidong <cyd@stupidchicken.com>
To: Adrian Robert <Adrian.B.Robert@gmail.com>
Cc: 3474@emacsbugs.donarmstrong.com
Subject: bug#3474: 23.0.94; Emacs.app crashes during typing (with patch)
Date: Sun, 07 Jun 2009 17:49:29 -0400 [thread overview]
Message-ID: <87vdn7ogt2.fsf@cyd.mit.edu> (raw)
Adrian, could you review this patch?
Wolfgang Lux <wolfgang.lux@gmail.com> wrote:
> I've encountered a few crashes in Emacs.app, which happened while
> typing when Emacs was a bit busy. It turns out that these crashes
> were due to an omitted null-pointer check at line 4165 of keyboard.c
> in function kbd_buffer_get_event(). The attached patch fixes this
> problem along with a second omitted null-pointer check in line 4323
> of the same function.
--- src/keyboard.c.~1.1005.~ 2009-05-28 17:08:04.000000000 +0200
+++ src/keyboard.c 2009-06-02 13:39:39.000000000 +0200
@@ -4162,7 +4162,8 @@
else
obj = Fcons (intern ("ns-unput-working-text"), Qnil);
kbd_fetch_ptr = event + 1;
- *used_mouse_menu = 1;
+ if (used_mouse_menu)
+ *used_mouse_menu = 1;
}
#endif
@@ -4319,7 +4320,8 @@
#endif
#ifdef HAVE_NS
/* certain system events are non-key events */
- if (event->kind == NS_NONKEY_EVENT)
+ if (used_mouse_menu
+ && event->kind == NS_NONKEY_EVENT)
*used_mouse_menu = 1;
#endif
next reply other threads:[~2009-06-07 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 21:49 Chong Yidong [this message]
2009-06-08 8:28 ` bug#3474: 23.0.94; Emacs.app crashes during typing (with patch) Adrian Robert
-- strict thread matches above, loose matches on Subject: below --
2009-06-05 11:57 Wolfgang Lux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdn7ogt2.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=3474@emacsbugs.donarmstrong.com \
--cc=Adrian.B.Robert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).