unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: 4896@emacsbugs.donarmstrong.com
Subject: bug#4896: DocView: Continuous mode
Date: Sun, 29 Nov 2009 00:52:57 +0200	[thread overview]
Message-ID: <87vdgu5jp9.fsf@mail.jurta.org> (raw)
In-Reply-To: <87my2dlcs3.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Mon, 23 Nov 2009 12:07:56 +0100")

I tried to add a menu item for `doc-view-continuous-mode' with
the following patch, but it doesn't look nice since currently
`doc-view-continuous-mode' is a variable.

If there are problems with that, maybe we should create a minor mode?
However, Continuous mode as a minor mode would complicate interactions
with another minor mode `doc-view-minor-mode' with questions like
should `C-c C-c' disable `doc-view-continuous-mode' and should another
`C-c C-c' re-enable it, and so on?

Index: lisp/doc-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
retrieving revision 1.92
diff -u -r1.92 doc-view.el
--- lisp/doc-view.el	25 Nov 2009 17:21:15 -0000	1.92
+++ lisp/doc-view.el	28 Nov 2009 22:51:02 -0000
@@ -332,13 +332,18 @@
 (easy-menu-define doc-view-menu doc-view-mode-map
   "Menu for Doc View mode."
   '("DocView"
+    ["Toggle display"		doc-view-toggle-display]
+    ["Continuous mode"		(setq doc-view-continuous-mode
+				      (not doc-view-continuous-mode))
+     :style toggle
+     :selected doc-view-continuous-mode]
+    "---"
     ["Set Slice"		doc-view-set-slice-using-mouse]
     ["Set Slice (manual)"	doc-view-set-slice]
     ["Reset Slice"		doc-view-reset-slice]
     "---"
     ["Search"			doc-view-search]
     ["Search Backwards"         doc-view-search-backward]
-    ["Toggle display"		doc-view-toggle-display]
     ))
 
 (defvar doc-view-minor-mode-map

-- 
Juri Linkov
http://www.jurta.org/emacs/





  parent reply	other threads:[~2009-11-28 22:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10  7:45 bug#4896: DocView: Continuous mode Juri Linkov
2009-11-10 18:03 ` Stefan Monnier
2009-11-12  9:57   ` Juri Linkov
2009-11-12 11:04     ` Tassilo Horn
2009-11-12 11:14       ` Juri Linkov
2009-11-12 13:10         ` Tassilo Horn
2009-11-12 15:49           ` Stefan Monnier
2009-11-12 16:01             ` Tassilo Horn
2009-11-23  9:47             ` Juri Linkov
2009-11-23 11:07               ` Tassilo Horn
2009-11-23 20:43                 ` Juri Linkov
2009-11-24 17:08                   ` Juri Linkov
2009-11-24 19:48                     ` Stefan Monnier
2009-11-25 17:28                       ` Juri Linkov
2009-11-28 22:52                 ` Juri Linkov [this message]
     [not found]                 ` <mailman.11748.1259452054.2239.bug-gnu-emacs@gnu.org>
2009-11-29  9:27                   ` Tassilo Horn
2009-11-29 16:05                     ` Juri Linkov
2009-11-29 19:11                       ` Tassilo Horn
2009-11-29 22:05                         ` Juri Linkov
2009-11-30  7:32                           ` Tassilo Horn
2009-11-30 12:04                             ` Juri Linkov
2009-11-30 13:36                               ` Tassilo Horn
2009-11-30 16:17                                 ` Juri Linkov
2009-11-24 17:06           ` Juri Linkov
2009-11-23  9:52       ` Juri Linkov
2009-11-23 11:03         ` Tassilo Horn
2009-11-23 21:36           ` Stefan Monnier
2009-11-24 17:06           ` Juri Linkov
2009-12-16  9:23             ` Juri Linkov
2010-02-01 23:30               ` bug#4896: Doc-view-mode with View-mode Juri Linkov
2010-02-02  2:45                 ` Stefan Monnier
2010-02-02 22:49                   ` Juri Linkov
2010-02-03  2:36                     ` Stefan Monnier
2010-02-04  0:01                       ` Juri Linkov
2010-02-04 15:43                         ` Stefan Monnier
2010-02-04 19:45                           ` Juri Linkov
2010-02-04 22:35                             ` Stefan Monnier
2022-04-28 12:08 ` bug#4896: DocView: Continuous mode Lars Ingebrigtsen
2022-04-28 17:35   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vdgu5jp9.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=4896@emacsbugs.donarmstrong.com \
    --cc=tassilo@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).