From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4896: Doc-view-mode with View-mode Date: Thu, 04 Feb 2010 21:45:04 +0200 Organization: JURTA Message-ID: <87vdedhrvz.fsf@mail.jurta.org> References: <87tyx2anec.fsf@mail.jurta.org> <87ocn8i9qn.fsf@mail.jurta.org> <87aayst364.fsf@thinkpad.tsdh.de> <87aaye1p3u.fsf@mail.jurta.org> <87r5rplcz9.fsf@thinkpad.tsdh.de> <87tywk12rm.fsf@mail.jurta.org> <87d42flgc0.fsf@mail.jurta.org> <87y6jcfs9u.fsf_-_@mail.jurta.org> <87k4uvyhia.fsf@mail.jurta.org> <87ljf93l75.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1265313485 12252 80.91.229.12 (4 Feb 2010 19:58:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Feb 2010 19:58:05 +0000 (UTC) Cc: 4896@emacsbugs.donarmstrong.com, Tassilo Horn To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 20:58:02 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nd7px-0005SS-EW for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2010 20:58:01 +0100 Original-Received: from localhost ([127.0.0.1]:52656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nd7pw-0005dK-Tq for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2010 14:58:01 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nd7pi-0005Ze-Jb for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:46 -0500 Original-Received: from [199.232.76.173] (port=58993 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nd7pi-0005ZO-3R for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:46 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nd7pc-0006y4-C8 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45941) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nd7pZ-0006xM-Eb for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2010 14:57:37 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Nd7p0-00005S-Hx; Thu, 04 Feb 2010 14:57:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2010 19:57:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 4896 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4896-submit@debbugs.gnu.org id=B4896.1265313409322 (code B ref 4896); Thu, 04 Feb 2010 19:57:02 +0000 Original-Received: (at 4896) by debbugs.gnu.org; 4 Feb 2010 19:56:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nd7om-000057-O4 for submit@debbugs.gnu.org; Thu, 04 Feb 2010 14:56:48 -0500 Original-Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nd7oW-0008WR-Es for 4896@emacsbugs.donarmstrong.com; Thu, 04 Feb 2010 14:56:44 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.52.53.cable.starman.ee [82.131.52.53]) by mx2.starman.ee (Postfix) with ESMTP id 630F23F4084; Thu, 4 Feb 2010 21:56:21 +0200 (EET) In-Reply-To: (Stefan Monnier's message of "Thu, 04 Feb 2010 10:43:11 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 04 Feb 2010 14:57:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34899 Archived-At: >>>> mode-class=special already doesn't disable view-mode when the ps/pdf/dvi >>>> document is visited as text because in this case the major mode is not >>>> doc-view-mode. >>> Fair enough, go for it, >> Do you mean putting mode-class=special on `doc-view-mode'? > > Yes. Actually the same problem exists also for `image-mode'. Visiting an image from an archive activates `view-mode'. This causes incorrect image browsing that uses view-mode scrolling commands instead of image scrolling commands. Maybe `image-mode' should have the property mode-class=special as well? === modified file 'lisp/image-mode.el' --- lisp/image-mode.el 2010-01-13 08:35:10 +0000 +++ lisp/image-mode.el 2010-02-04 19:44:42 +0000 @@ -317,6 +317,8 @@ (defvar image-minor-mode-map (defvar bookmark-make-record-function) +(put 'image-mode 'mode-class 'special) + ;;;###autoload (defun image-mode () "Major mode for image files. -- Juri Linkov http://www.jurta.org/emacs/