* bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords
@ 2010-12-22 19:01 Jari Aalto
2010-12-29 11:02 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: Jari Aalto @ 2010-12-22 19:01 UTC (permalink / raw)
To: 7712
Package: emacs
Version: 23.2+1-5.1
Severity: minor
lisp/textmodes/conf-mode.el uses macro expansion backtick (`) in here:
(defvar conf-font-lock-keywords
=> `(;; [section] (do this first because it may look like a parameter)
("^[ \t]*\\[\\(.+\\)\\]" 1 'font-lock-type-face)
;; var=val or var[index]=val
("^[ \t]*\\(.+?\\)\\(?:\\[\\(.*?\\)\\]\\)?[ \t]*="
(1 'font-lock-variable-name-face)
(2 'font-lock-constant-face nil t))
;; section { ... } (do this last because some assign ...{...)
("^[ \t]*\\([^=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend))
"Keywords to hilight in Conf mode.")
Everywhere else it uses single quote:
(defvar conf-javaprop-font-lock-keywords
=> '(;; var=val
("^[ \t]*\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(\\..+?\\)?\\)?\\)?\\)?\\)?\\)?\\([:= \t]\\|$\\)"
(1 'font-lock-variable-name-face)
(2 'font-lock-constant-face nil t)
(3 'font-lock-variable-name-face nil t)
(4 'font-lock-constant-face nil t)
(5 'font-lock-variable-name-face nil t)
(6 'font-lock-constant-face nil t)
(7 'font-lock-variable-name-face nil t)))
"Keywords to hilight in Conf Java Properties mode.")
...
Perhaps the conf-font-lock-keywords should also use single quote?
-- System Information
Debian Release: squeeze/sid
APT Prefers testing
APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8
-- Versions of packages `emacs depends on'.
Depends:
emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting
emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting
emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords
2010-12-22 19:01 bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords Jari Aalto
@ 2010-12-29 11:02 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-12-29 11:02 UTC (permalink / raw)
To: Jari Aalto; +Cc: 7712
Jari Aalto <jari.aalto@cante.net> writes:
> lisp/textmodes/conf-mode.el uses macro expansion backtick (`) in here:
> Perhaps the conf-font-lock-keywords should also use single quote?
Sure. Committed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-29 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-22 19:01 bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords Jari Aalto
2010-12-29 11:02 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).