unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Alp Aker <alptekin.aker@gmail.com>
Cc: 9175@debbugs.gnu.org
Subject: bug#9175: [PATCH] 24.0.50: Images colors on NextStep do not default correctly
Date: Thu, 28 Jul 2011 14:29:19 -0400	[thread overview]
Message-ID: <87vcuml0n4.fsf@stupidchicken.com> (raw)
In-Reply-To: <CACxch4qdSpZ62qX2sMOeF7_s0FLr1HbFEEtaX5OURPr0CrQUoQ@mail.gmail.com> (Alp Aker's message of "Tue, 26 Jul 2011 14:44:17 -0400")

Alp Aker <alptekin.aker@gmail.com> writes:

> Image types that support :foreground and :background keywords in their
> image descriptors are supposed to default to the frame foreground and
> background colors when the relevant colors aren't specified.  On NS,
> however, these default to black.  An easy test case is provided by
> visiting a mono PBM image file (such as etc/images/splash.pbm) in
> image-mode; what one will see is simply a black square.
>
> Diagnostic: The image loading functions in image.c take the default
> colors from the frame's foreground_pixel and background_pixel fields,
> but on NS the relevant frame parameter handlers don't set those
> fields.  The following patch corrects that.

Thanks, applied.





      reply	other threads:[~2011-07-28 18:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 18:44 bug#9175: [PATCH] 24.0.50: Images colors on NextStep do not default correctly Alp Aker
2011-07-28 18:29 ` Chong Yidong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcuml0n4.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=9175@debbugs.gnu.org \
    --cc=alptekin.aker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).