From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#11738: 24.1.50; Regression: `modify-frame-parameters' is broken for `left' & `top' Date: Wed, 18 Jul 2012 16:10:23 +0800 Message-ID: <87vchla3rk.fsf@gnu.org> References: <410D9B3E38A743B3B0259C9376E528A9@us.oracle.com> <25492B287E9942E3B6C798C3CD0DFD22@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1342599066 6656 80.91.229.3 (18 Jul 2012 08:11:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2012 08:11:06 +0000 (UTC) Cc: Paul Eggert , 11738@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 18 10:11:06 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SrPLd-0000wv-Pq for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Jul 2012 10:11:05 +0200 Original-Received: from localhost ([::1]:33658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrPLc-0001lF-Uf for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Jul 2012 04:11:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrPLX-0001l0-7w for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2012 04:11:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrPLW-0000rF-7E for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2012 04:10:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrPLW-0000r2-3Q for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2012 04:10:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SrPRO-0008Pn-6h for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2012 04:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jul 2012 08:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11738 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11738-submit@debbugs.gnu.org id=B11738.134259939932315 (code B ref 11738); Wed, 18 Jul 2012 08:17:02 +0000 Original-Received: (at 11738) by debbugs.gnu.org; 18 Jul 2012 08:16:39 +0000 Original-Received: from localhost ([127.0.0.1]:47343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrPR0-0008PA-OX for submit@debbugs.gnu.org; Wed, 18 Jul 2012 04:16:38 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:59907) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrPQx-0008P2-VB for 11738@debbugs.gnu.org; Wed, 18 Jul 2012 04:16:36 -0400 Original-Received: from [155.69.19.199] (port=53559 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SrPL3-0008W1-Dq; Wed, 18 Jul 2012 04:10:30 -0400 In-Reply-To: <25492B287E9942E3B6C798C3CD0DFD22@us.oracle.com> (Drew Adams's message of "Mon, 2 Jul 2012 09:36:17 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62083 Archived-At: "Drew Adams" writes: > emacs -Q > In *scratch*: > (setq new (- (frame-parameter nil 'left) 10)) > (setq new `(left + ,new)) > (modify-frame-parameters nil (list new)) > > IOW, try to set `left' or `top' to a value that is a cons whose car is > `left' or `top', whose cadr is `+' or `-', and whose caddr is some new > value. Nothing happens. Paul Eggert's revision 108370 is responsible. The part below was bogus; reverted in trunk. Paul---please be more careful when doing such code-churning. *************** *** 2913,2919 **** } /* Don't die if just one of these was set. */ ! if (EQ (left, Qunbound)) { left_no_change = 1; if (f->left_pos < 0) --- 2916,2922 ---- } /* Don't die if just one of these was set. */ ! if (! TYPE_RANGED_INTEGERP (int, left)) { left_no_change = 1; if (f->left_pos < 0) *************** *** 2921,2927 **** else XSETINT (left, f->left_pos); } ! if (EQ (top, Qunbound)) { top_no_change = 1; if (f->top_pos < 0) --- 2924,2930 ---- else XSETINT (left, f->left_pos); } ! if (! TYPE_RANGED_INTEGERP (int, top)) { top_no_change = 1; if (f->top_pos < 0)