From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files Date: Wed, 24 Oct 2012 15:31:33 +0200 Message-ID: <87vce0xah6.fsf@web.de> References: <87r4t1sk9o.fsf@web.de> <87sjdhily5@ch.ristopher.com> <06AF8E7E174A4F768ADB2B901755EA3C@us.oracle.com> <87sj95ad3l.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1351085542 28325 80.91.229.3 (24 Oct 2012 13:32:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2012 13:32:22 +0000 (UTC) Cc: 11795@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 24 15:32:30 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TR14P-0006GX-Io for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2012 15:32:29 +0200 Original-Received: from localhost ([::1]:59832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR14H-0004Xe-QD for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2012 09:32:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR146-0004WA-0E for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2012 09:32:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR140-00040J-7Q for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2012 09:32:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR140-00040E-3t for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2012 09:32:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TR15t-0004Ho-Nl for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2012 09:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Oct 2012 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11795 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11795-submit@debbugs.gnu.org id=B11795.135108560416431 (code B ref 11795); Wed, 24 Oct 2012 13:34:01 +0000 Original-Received: (at 11795) by debbugs.gnu.org; 24 Oct 2012 13:33:24 +0000 Original-Received: from localhost ([127.0.0.1]:58989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR15I-0004Gy-4l for submit@debbugs.gnu.org; Wed, 24 Oct 2012 09:33:24 -0400 Original-Received: from mout.web.de ([212.227.17.11]:55195) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR15F-0004Gk-H0 for 11795@debbugs.gnu.org; Wed, 24 Oct 2012 09:33:22 -0400 Original-Received: from drachen.dragon ([89.204.137.163]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0M7blv-1TBhQb3j9D-00wkQJ; Wed, 24 Oct 2012 15:31:15 +0200 In-Reply-To: <87sj95ad3l.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 23 Oct 2012 11:05:04 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-Provags-ID: V02:K0:4vFx8ro+2WQ1Ck1lEJLqXVbxVminu+4m54WaneyPkAV YtP9vF04jW1/jnrG8XQilmSsyzvcQuCoCYGOlcaQbGxKuJIWTd h69yFebdADenHHR689maMM+2pVLksv2kLaSJl5E0HSqZojnwTx wwE/5ndqdPidPxkm/S7jpuAS0MlYUcWyx09chJIpsQSd3YD3zh 8ItxL+cOPTVAofAokw07FdfGXF+Ry+JjUVSN2Ojt44= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65966 Archived-At: Juri Linkov writes: > > But shouldn't Wdired respect the user's setting of option > > `dired-keep-marker-rename'? IOW, shouldn't users be able to control > > whether > > exiting wdired removes marks? > > When `dired-keep-marker-rename' is customized to a character like ?R or ?M, > now `wdired-finish-edit' adds a new marker on the files renamed by wdired. > This is new behavior. Strictly speaking, it is consistent with the meaning > of `dired-keep-marker-rename', so I'm not sure if a new option is necessary > to control this. But at least when someone wants to put markers only on the > files moved by `dired-do-rename', but not on the files renamed by wdired, > this is still possible to do by adding to ~/.emacs something like: > > (defadvice wdired-finish-edit (around my-wdired-finish-edit act) > (let ((dired-keep-marker-rename t)) > ad-do-it)) I think you're right, some people may want to have a behavior different than that defined by `dired-keep-marker-rename'. And we should avoid the necessity for users to use something nontrivial like `defadvice' to control this. So, introducing an new option `wdired-keep-marker-rename' would IMHO make sense. The default value could be t, at least that's what I think would be most intuitive. Michael.