From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20119: 25.0.50; tramp-test30-special-characters hangs on Cygwin Date: Wed, 18 Mar 2015 20:53:16 +0100 Message-ID: <87vbhyt74j.fsf@gmx.de> References: <55070302.8030607@cornell.edu> <87r3so99sk.fsf@gmx.de> <55070931.3080502@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426708471 2933 80.91.229.3 (18 Mar 2015 19:54:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Mar 2015 19:54:31 +0000 (UTC) Cc: 20119@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 18 20:54:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYK2d-0006pB-BZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Mar 2015 20:54:11 +0100 Original-Received: from localhost ([::1]:35525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYK2c-00026u-Jq for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Mar 2015 15:54:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYK2Y-00026n-PZ for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 15:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYK2U-0007NW-JZ for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 15:54:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYK2U-0007NQ-H6 for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 15:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYK2U-0002vA-An for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 15:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Mar 2015 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20119 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20119-submit@debbugs.gnu.org id=B20119.142670840811190 (code B ref 20119); Wed, 18 Mar 2015 19:54:02 +0000 Original-Received: (at 20119) by debbugs.gnu.org; 18 Mar 2015 19:53:28 +0000 Original-Received: from localhost ([127.0.0.1]:51954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYK1v-0002uQ-ST for submit@debbugs.gnu.org; Wed, 18 Mar 2015 15:53:28 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:59162) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYK1u-0002uH-3N for 20119@debbugs.gnu.org; Wed, 18 Mar 2015 15:53:26 -0400 Original-Received: from detlef.gmx.de ([87.146.33.181]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LviG8-1Zb25i1i5U-017W5H; Wed, 18 Mar 2015 20:53:18 +0100 In-Reply-To: <55070931.3080502@cornell.edu> (Ken Brown's message of "Mon, 16 Mar 2015 12:47:45 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:qcBYQoWcKHaMAd+sRkC1pzKdpNt8SeslHWKNAOfFrxYWa5cvw7A 4fcAgMZr7I4ghA913GPKniLOfHe7skfGQbcBsUH0pR1nACDDZtkcdmRkfvClzxWsBcpj/6W L7ptc8pZbEtnQimiuEvJfSe6+Bi+QvedjwPfnH7/Dk4GxbtEq0aZq/KozswuF2CZNMt3h+g Fm7Phf1+kQTWgAOcP/6ew== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100633 Archived-At: Ken Brown writes: > Hi Michael, Hi Ken, >> "\t" shall be expanded as . And leading (or trailing) spaces are >> also not allowed in file names on w32; likely it is the same for cygwin. > > In the context of file names on Cygwin, "\t" is not expanded to > because of the special treatment of the backslash. But leading and > trailing spaces are fine; see my patch. Your patch works fine, but I'm still curious: what happens with this test, if we don't pass "\t" but the character in the file name? This shall work, shouldn't it? Maybe you have time to test the follwing patch: --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/tramp/test/tramp-tests.el.~master~ 2015-03-18 20:50:29.399389219 +0100 --- /home/albinus/src/tramp/test/tramp-tests.el 2015-03-18 16:43:56.073936927 +0100 *************** *** 1522,1528 **** "Run a simple but comprehensive test over every file in FILES." (let ((tmp-name1 (tramp--test-make-temp-name)) (tmp-name2 (tramp--test-make-temp-name 'local)) ! (files (delq nil files))) (unwind-protect (progn (make-directory tmp-name1) --- 1522,1529 ---- "Run a simple but comprehensive test over every file in FILES." (let ((tmp-name1 (tramp--test-make-temp-name)) (tmp-name2 (tramp--test-make-temp-name 'local)) ! (files (mapcar (lambda (x) (with-output-to-string (princ x))) ! (delq nil files)))) (unwind-protect (progn (make-directory tmp-name1) *************** *** 1629,1635 **** (tramp--test-check-files (if (tramp--test-smb-or-windows-nt-p) "foo bar baz" ! (if (or (tramp--test-adb-p) (eq system-type 'cygwin)) " foo bar baz " " foo\tbar baz\t")) "$foo$bar$$baz$" --- 1630,1636 ---- (tramp--test-check-files (if (tramp--test-smb-or-windows-nt-p) "foo bar baz" ! (if (tramp--test-adb-p) " foo bar baz " " foo\tbar baz\t")) "$foo$bar$$baz$" --8<---------------cut here---------------end--------------->8--- > Ken Best regards, Michael.