From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aku Kotkavuo Newsgroups: gmane.emacs.bugs Subject: bug#20452: 25.0.50; [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3 Date: Wed, 29 Apr 2015 02:57:04 +0300 Message-ID: <87vbgflsbz.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430266893 22697 80.91.229.3 (29 Apr 2015 00:21:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Apr 2015 00:21:33 +0000 (UTC) To: 20452@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 29 02:21:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YnFkd-000235-Gv for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Apr 2015 02:21:19 +0200 Original-Received: from localhost ([::1]:36293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnFkb-0002w1-LJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Apr 2015 20:21:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnFkT-0002s6-Ma for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 20:21:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnFkO-0006N2-MA for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 20:21:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnFkO-0006Mt-JU for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 20:21:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YnFkO-0006UE-0S for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 20:21:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aku Kotkavuo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2015 00:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.143026682624865 (code B ref -1); Wed, 29 Apr 2015 00:21:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Apr 2015 00:20:26 +0000 Original-Received: from localhost ([127.0.0.1]:55330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnFjj-0006Sw-QJ for submit@debbugs.gnu.org; Tue, 28 Apr 2015 20:20:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46813) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnFNp-0005uR-Bv for submit@debbugs.gnu.org; Tue, 28 Apr 2015 19:57:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnFNj-0005Je-6C for submit@debbugs.gnu.org; Tue, 28 Apr 2015 19:57:39 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnFNj-0005Ja-35 for submit@debbugs.gnu.org; Tue, 28 Apr 2015 19:57:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnFNi-0002V2-4q for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 19:57:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnFNe-0005JQ-Vp for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 19:57:38 -0400 Original-Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:35933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnFNe-0005JI-Ne for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2015 19:57:34 -0400 Original-Received: by lbbqq2 with SMTP id qq2so8260515lbb.3 for ; Tue, 28 Apr 2015 16:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=uZx8yxrLGlmt/ZiG09VzusJPQYlRZQU/RSV/X6Sc9fY=; b=hgzmHlNi7iRgeoDL9yNww2vkIgcf8sr+llzIwxoX/+GK9d2XUXBpPU7PX40uwWvIw8 dq6vfIIWLMNz3NnCCvMMFLZtYlOBIy3gMYrQY4nxSsdWPkIRcUKbh9qgYrVVP0z3VI6P 2cp+r8eh7X/PqHUKib7uXmRiJBNmnRat8XKsZuJU2EI1RAgNO7duM8lGTiE17ZCqjxKo 8lYhJ8aIXdr65nuBUzEPnPZfY7PScxhFNHAbEqMPA/KopyZbth1z1VJ3OuwU9ePf6TZd rDj9uRFIkT18xsu8wm38J2VzlRWkoQlL39PDxh3XK+psno7TdnheUsxOXlYdSyxkWaE6 YyMA== X-Received: by 10.152.43.110 with SMTP id v14mr15776925lal.4.1430265453317; Tue, 28 Apr 2015 16:57:33 -0700 (PDT) Original-Received: from ubuntu (212-149-202-89.bb.dnainternet.fi. [212.149.202.89]) by mx.google.com with ESMTPSA id at2sm5927843lbc.12.2015.04.28.16.57.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2015 16:57:31 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Tue, 28 Apr 2015 20:20:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102195 Archived-At: When compiling the latest version of Emacs, I encountered a warning about my GTK+ version during the configuration phase: > configure: WARNING: Your version of Gtk+ will have problems with > closing open displays. This is no problem if you just use > one display, but if you use more than one and close one of them > Emacs may crash. This seemed curious to me, so I dug in a little deeper and noticed that this part of the configure script was written in 2008 and was supposed to warn users of GTK+ 2.8 and earlier, released in 2005. I'm using GTK+ 3.14. I wrote a tiny patch to fix the check. (Maybe the whole warning should be removed? Is there someone still using GTK+ 2.8 or older?) >From 25ada920247cda3ed9d074c7e3eab6313548370d Mon Sep 17 00:00:00 2001 From: Aku Kotkavuo Date: Wed, 29 Apr 2015 00:32:19 +0300 Subject: [PATCH] Don't warn about too old GTK+ when using GTK+ 3 --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d2f21ee..2d2fefa 100644 --- a/configure.ac +++ b/configure.ac @@ -2496,7 +2496,7 @@ if test x"$pkg_check_gtk" = xyes; then GTK_OBJ="gtkutil.o $GTK_OBJ" term_header=$gtk_term_header USE_X_TOOLKIT=none - if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then + if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0 || "$PKG_CONFIG" gtk+-3.0; then : else AC_MSG_WARN([[Your version of Gtk+ will have problems with -- 2.1.4