unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Aku Kotkavuo <aku.kotkavuo@gmail.com>
To: 20452@debbugs.gnu.org
Subject: bug#20452: 25.0.50; [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3
Date: Wed, 29 Apr 2015 02:57:04 +0300	[thread overview]
Message-ID: <87vbgflsbz.fsf@gmail.com> (raw)


When compiling the latest version of Emacs, I encountered a warning
about my GTK+ version during the configuration phase:

> configure: WARNING: Your version of Gtk+ will have problems with
>        closing open displays.  This is no problem if you just use
>        one display, but if you use more than one and close one of them
>        Emacs may crash.

This seemed curious to me, so I dug in a little deeper and noticed that
this part of the configure script was written in 2008 and was supposed
to warn users of GTK+ 2.8 and earlier, released in 2005. I'm using GTK+
3.14.

I wrote a tiny patch to fix the check.

(Maybe the whole warning should be removed? Is there someone still using
GTK+ 2.8 or older?)


From 25ada920247cda3ed9d074c7e3eab6313548370d Mon Sep 17 00:00:00 2001
From: Aku Kotkavuo <aku.kotkavuo@gmail.com>
Date: Wed, 29 Apr 2015 00:32:19 +0300
Subject: [PATCH] Don't warn about too old GTK+ when using GTK+ 3

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d2f21ee..2d2fefa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2496,7 +2496,7 @@ if test x"$pkg_check_gtk" = xyes; then
     GTK_OBJ="gtkutil.o $GTK_OBJ"
     term_header=$gtk_term_header
     USE_X_TOOLKIT=none
-    if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then
+    if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0 || "$PKG_CONFIG" gtk+-3.0; then
       :
     else
       AC_MSG_WARN([[Your version of Gtk+ will have problems with
-- 
2.1.4





             reply	other threads:[~2015-04-28 23:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 23:57 Aku Kotkavuo [this message]
2015-04-29  3:25 ` bug#20452: 25.0.50; [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3 Stefan Monnier
2015-04-29  4:16   ` Jan D.
2015-04-29  7:16     ` Glenn Morris
2015-04-29 10:43       ` Aku Kotkavuo
2015-04-29 13:30         ` Stefan Monnier
2015-05-07 18:09           ` Jan D.
2015-04-29 15:46         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbgflsbz.fsf@gmail.com \
    --to=aku.kotkavuo@gmail.com \
    --cc=20452@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).