From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20943: 25.0.50; Dired buffers are not always auto-reverted Date: Fri, 10 Jul 2015 08:01:48 +0200 Message-ID: <87vbdszh2r.fsf@gmx.de> References: <87y4j1oy87.fsf@openmailbox.org> <87pp41cvl1.fsf@openmailbox.org> <83615tv14o.fsf@gnu.org> <874mldtkl9.fsf@openmailbox.org> <874mld18cx.fsf@gmx.de> <87io9t3yoh.fsf@openmailbox.org> <83r3ogbm4s.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1436508144 26668 80.91.229.3 (10 Jul 2015 06:02:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Jul 2015 06:02:24 +0000 (UTC) Cc: 20943@debbugs.gnu.org, Mark Karpov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 10 08:02:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZDRO0-0000Ly-LX for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jul 2015 08:02:12 +0200 Original-Received: from localhost ([::1]:43100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDRNz-0008Se-PD for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jul 2015 02:02:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDRNr-0008SZ-OM for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 02:02:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDRNq-00019h-I7 for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 02:02:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDRNq-00019b-Ep for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 02:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZDRNq-0001Mv-7k for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 02:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jul 2015 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20943-submit@debbugs.gnu.org id=B20943.14365081205251 (code B ref 20943); Fri, 10 Jul 2015 06:02:02 +0000 Original-Received: (at 20943) by debbugs.gnu.org; 10 Jul 2015 06:02:00 +0000 Original-Received: from localhost ([127.0.0.1]:45751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDRNn-0001Md-Oz for submit@debbugs.gnu.org; Fri, 10 Jul 2015 02:02:00 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:59268) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDRNl-0001MP-7E for 20943@debbugs.gnu.org; Fri, 10 Jul 2015 02:01:57 -0400 Original-Received: from detlef.gmx.de ([93.209.80.73]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Lkjuq-1YdH9F34hY-00aS8j; Fri, 10 Jul 2015 08:01:49 +0200 In-Reply-To: <83r3ogbm4s.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jul 2015 08:46:27 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:FJcgBD8orJ0lsW0dDQuu18CQGpEb8tuj2u7Rmwb6y3kLWjlHgyx 72Zbvpwb80O6WdwprbNklwvfrTXxjr1x9CahconlxYMK26TOfV4jjXMX3AV0ulZw+Yk7NGa 1paXBkqaw9meNpZGxZ0xckQazfigXtPkD6DdweNBgqQoJhU0ysWD1rutaI4EWoYL3Ovxw37 +P6DNcsQkdladuBRK3fSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:JdDYlD6737k=:s/4VEkCjSRMeSrDpUwNBGT ETeO3gXabJyB067WAxY+ezKw6EpEo2rB6HCHMAj0YyGs0YB/yf37Nh6qHveXwioXei89iIlWu F0AusHpU24+BIRS8J+B6zEUHbeV+lN4tqptAibcrNmSpBjbmgVtxnY4OC7ccjkBfXl7XKJRFs TeZGrSJZREJrbG4vVQSo9/xVandKRNWPW0WT2k6Zj3/1LR+Aw/lLwGJBJiz+ZZH/iAMrzujcK RccWMZPyqPVWyLGO5aAaRBeZFj9z5WTu0XuXjBP7OQ2oOmVTFde7mlFCVL2WoUSZSh5wGXU0Y 9SShJDuSPkdZGvAm7eRqUDaZNWZ3f2c5RjxuKmjzG/ind0nnQaCapjP1pbsGx7t0n7DLu1EIF hkkTlXYB7dmnwSMPbo91Oi1sMMgbFfDSJfypbPHzmun/jXWdXPLTyfkLL3wre1q3TREZ1lldS DTcFqbdyW4mfx0qT8zXHyT3+Na05ph+CC7uxexTe+kqK9t2zwqCYgC+SNBMhLD4ml8/Vz/WVh oXefPnd/SiYeBPBuL+AqpZ+gvxxw3H1BRC5U9SDSknlGZJfXQNsi8+PlAD24Tq7szM3b2MbAV GSL5xINgjGx3BxAK6GDETRTDuQe9K4BhhKveM5BwsYh0rrkza6ufWxn0b3tZim/CKxjRCXvbD 1X0XNXLFnTVAFBqqhgh88qo0UQqrWdC3MS5RiXudDNa9mESabxEB75uzinKMg989RzwU= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104873 Archived-At: Eli Zaretskii writes: > How about instead introducing a buffer-local variable, say > auto-revert-when-modified, which Dired will set to a non-nil value, > and auto-revert will test? Then, when this variable is non-nil, > auto-revert could disregard the modified status, and revert the > buffer, if stale, anyway. I believe we could use the existing -stale-p mechanism for that purpose. dired-stale-p shall decide to return a proper value, even if the dired buffer is modified. It will follow the same logic as you have proposed above. And we could implement different logic, depending whether default-directory is a remote file name. auto-revert-handler shall not cease to work unconditionally, when buffer-modified-p is non-nil. This check shall be done only for buffers with a related file (buffer-file-name is non-nil). For all other buffers, -stale-p shall decide, whether buffer-modified-p must be taken into account. Thinking about, we might even extract a new function auto-revert-buffer-with-file-stale-p from auto-revert-handler. This would handle the case for buffers with a non-nil buffer-file-name. auto-revert-handler would call always the buffer-local -stale-p function; the code would be cleaner. I will try to write such a patch if nobody beats me. Unfortunately, it will take time; I'm still suffering from my health problems. Best regards, Michael.