bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Setting ‘blink-matching-delay’ has no effect:

  (setq blink-matching-delay 0.5) ; 1 second delay is used
  (setq blink-matching-delay 3)   ; still 1 second delay is used

I read source code and saw that ‘sit-for’ is used to implement
delay. I've tested it and it works with floating point arguments as well
as any integer arguments on my system.



In GNU Emacs 25.0.50.16 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6)
 of 2015-08-11 on arch
Repository revision: acde89a2088180831e506d0c4255b306a339e291
Windowing system distributor `The X.Org Foundation', version 11.0.11702000
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: H

Minor modes in effect:
  shell-dirtrack-mode: t
  interactive-haskell-mode: t
  haskell-indentation-mode: t
  diff-auto-refine-mode: t
  hl-todo-mode: t
  flycheck-mode: t
  flyspell-mode: t
  whitespace-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  show-paren-mode: t
  minibuffer-electric-default-mode: t
  ido-vertical-mode: t
  ido-ubiquitous-mode: t
  ido-everywhere: t
  highlight-line-mode: t
  global-auto-revert-mode: t
  global-aggressive-indent-mode: t
  display-time-mode: t
  delete-selection-mode: t
  ace-popup-menu-mode: t
  smartparens-global-mode: t
  smartparens-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: do-auto-fill
  transient-mark-mode: t
  auto-fill-mode: 1

Recent messages:
Reading active file from archive via nnfolder...done
Reading active file via nndraft...done
Checking new news...done
Are you sure you want to quit reading news? (y or n) y
Saving file /home/mark/.newsrc...
Wrote /home/mark/.newsrc
Saving /home/mark/.newsrc.eld...
Saving file /home/mark/.newsrc.eld...
Wrote /home/mark/.newsrc.eld
Saving /home/mark/.newsrc.eld...done

Load-path shadows:
None found.

Features:
(browse-url gnus-draft gnus-async gnus-ml disp-table nndraft nnmh
nnfolder utf-7 gnus-agent gnus-srvr gnus-score score-mode nnvirtual
gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap nntp
gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap
nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range gnus-win gnus gnus-ems nnheader wid-edit epa-file epa derived
epg gnutls network-stream nsm starttls tls mailalias smtpmail qp shadow
sort mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mail-utils eieio-opt speedbar
sb-image ezimage dframe misearch multi-isearch jka-compr ace-window vc
vc-dispatcher haskell-doc inf-haskell haskell-decl-scan imenu shell
pcomplete haskell haskell-completions haskell-load haskell-commands
highlight-uses-mode haskell-modules haskell-sandbox haskell-repl
haskell-debug haskell-interactive-mode haskell-presentation-mode
haskell-collapse haskell-navigate-imports haskell-compile
haskell-process haskell-session url-util url-parse auth-source gnus-util
mm-util mail-prsvr password-cache url-vars json haskell-indentation
haskell-font-lock smartparens-haskell haskell-mode haskell-string
haskell-sort-imports haskell-lexeme haskell-align-imports haskell-compat
haskell-complete-module noutline outline flymake etags xref project
eieio eieio-core compile comint dabbrev ansi-color hl-line dired
help-fns vc-git diff-mode bookmark pp rainbow-delimiters hl-todo
flycheck-haskell haskell-cabal haskell-utils haskell-customize flycheck
find-func rx flyspell ispell whitespace mk-visual solarized-dark-theme
solarized mk-texinfo mk-tex mk-python mk-prolog mk-org mk-markdown
mk-man mk-magit mk-lisp mk-ibuffer mk-haskell mk-gnus mk-eshell mk-erc
mk-elisp mk-dired mk-diff mk-clojure kill-or-bury-alive mk-calendar mk-c
mk-bookmark mk-minor-modes common-lisp-snippets yasnippet cl
whole-line-or-region paren minibuf-eldef ido-vertical-mode
ido-ubiquitous ido-completing-read+ cl-macs gv ido highlight-line
autorevert filenotify cl-seq aggressive-indent easy-mmode time delsel
ace-popup-menu smartparens-config smartparens byte-opt thingatpt
mk-global edmacro kmacro ace-link avy ring misc server mk-utils subr-x f
dash s ucs-normalize finder-inf tex-site fix-word advice slime-autoloads
info bytecomp byte-compile cl-extra help-mode seq cl-loaddefs pcase
cl-lib cconv package easymenu epg-config time-date mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 480903 153698)
 (symbols 48 44382 35)
 (miscs 40 215 1655)
 (strings 32 96076 66922)
 (string-bytes 1 2845438)
 (vectors 16 68692)
 (vector-slots 8 1900428 168005)
 (floats 8 592 1757)
 (intervals 56 2701 733)
 (buffers 976 33)
 (heap 1024 61611 7446))

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/18/2015 03:55 PM, Mark Karpov wrote:
>
> Setting ‘blink-matching-delay’ has no effect:
>
>    (setq blink-matching-delay 0.5) ; 1 second delay is used
>    (setq blink-matching-delay 3)   ; still 1 second delay is used

Works fine here. I see an appropriate delay as set above.

Try reproducing it starting with 'emacs -Q'.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 08/18/2015 03:55 PM, Mark Karpov wrote:
>>
>> Setting ‘blink-matching-delay’ has no effect:
>>
>>    (setq blink-matching-delay 0.5) ; 1 second delay is used
>>    (setq blink-matching-delay 3)   ; still 1 second delay is used
>
> Works fine here. I see an appropriate delay as set above.
>
> Try reproducing it starting with 'emacs -Q'.

Doesn't work for me even with ‘emacs -Q’. Are you sure you are seeing
0.5 second delay?

Here is how I test it:

1. Start Emacs with ‘-Q’ flag.

2. Evaluate:

  (setq blink-matching-delay 0.5)

3. Re-check its value and description: ‘C-h v blink-matching-delay RET’.

4. Open some file with long data within parentheses, scroll down so you
   don't see opening parenthesis.

5. Delete closing parenthesis and type it manually.

6. Period of time for which opening parenthesis is shown is always 1
   second. You can set it to 5 seconds, it will be 1 second no matter
   what.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/18/2015 05:01 PM, Mark Karpov wrote:

> 4. Open some file with long data within parentheses, scroll down so you
>     don't see opening parenthesis.

So this is about the case when you don't see it. You haven't mentioned 
this before.

The behavior you're describing was a recent regression, and it was fixed 
in b892438d7 (yesterday). I've touched up on that fix now, but either 
way should work for you.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

I've pulled/rebuilded Emacs. Now it doesn't just to opening parenthesis
at all.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/18/2015 08:34 PM, Mark Karpov wrote:
>
> I've pulled/rebuilded Emacs. Now it doesn't just to opening parenthesis
> at all.

It does, as long as the opening paren is visible in the current window. 
That has always been its behavior.

If the opening paren is not visible, its line is merely displayed in the 
echo area.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 08/18/2015 08:34 PM, Mark Karpov wrote:
>>
>> I've pulled/rebuilded Emacs. Now it doesn't just to opening parenthesis
>> at all.
>
> It does, as long as the opening paren is visible in the current window. That
> has always been its behavior.
>
> If the opening paren is not visible, its line is merely displayed in the
> echo area.

Strange. I tried in combination with:

  (setq blink-matching-paren 'jump)

Nothing seem to produce that effect, I really liked it. I can't believe
this handy behavior was not intentional and now it's lost.

If that behavior that I liked so much was sort of bug, consider adding
it as a feature.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/18/2015 08:45 PM, Mark Karpov wrote:

> Nothing seem to produce that effect, I really liked it. I can't believe
> this handy behavior was not intentional and now it's lost.
>
> If that behavior that I liked so much was sort of bug, consider adding
> it as a feature.

All right, you can try (setq blink-matching-paren 'jump-offscreen) now.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 08/18/2015 08:45 PM, Mark Karpov wrote:
>
>> Nothing seem to produce that effect, I really liked it. I can't believe
>> this handy behavior was not intentional and now it's lost.
>>
>> If that behavior that I liked so much was sort of bug, consider adding
>> it as a feature.
>
> All right, you can try (setq blink-matching-paren 'jump-offscreen) now.

I'm sorry, still doesn't work for me :-(

I'm testing it the same way described above, but evaluating

  (setq blink-matching-paren 'jump-offscreen)

after setting of ‘blink-matching-delay’.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/19/2015 12:31 PM, Mark Karpov wrote:

> I'm sorry, still doesn't work for me :-(

Have you made a pull and (important!) rebuilt Emacs?

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Have you made a pull and (important!) rebuilt Emacs?

Yes, of course. I'm sure I'm using Emacs with your recent changes,
because ‘C-h v blink-matching-paren RET’ results in:

  blink-matching-paren is a variable defined in ‘simple.el’.
  Its value is jump-offscreen
  Original value was t
  
  Documentation:
  Non-nil means show matching open-paren when close-paren is inserted.
  If t, highlight the paren.  If ‘jump’, briefly move cursor to its
  position.  If ‘jump-offscreen’, move cursor there even if the
  position is off screen.  With any other non-nil value, the
  off-screen position of the opening paren will be shown in the
  echo area.
  
  You can customize this variable.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/19/2015 12:55 PM, Mark Karpov wrote:

> Yes, of course. I'm sure I'm using Emacs with your recent changes,
> because ‘C-h v blink-matching-paren RET’ results in:

You should try 'make bootstrap' anyway.

And what doesn't work for you exactly? The jump offscreen, or 
customizing its delay value?

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Dmitry Gutov <dgutov@yandex.ru> writes:

> And what doesn't work for you exactly? The jump offscreen, or customizing
> its delay value?

Nevermind, I just rechecked it with ‘-Q’ flag. It works! Everything
works: delay time and jumping. Thank you. I need to investigate why it
doesn't work with my configuration…

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Now I know that it doesn't work when ‘show-paren-mode’ is enabled. I
would like to use this blinking feature together with
‘show-paren-mode’. Is it possible?

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/19/2015 01:23 PM, Mark Karpov wrote:
>
> Now I know that it doesn't work when ‘show-paren-mode’ is enabled. I
> would like to use this blinking feature together with
> ‘show-paren-mode’. Is it possible?

Sorry, it's too much for me to get into right now.

But this should probably be implemented in show-paren-mode. Please file 
a separate bug with this feature request.

And please clarify: the way it works now, are you going to use 
`jump-offscreen'? If not, I'm going to revert that commit.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Mark Karpov]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Sorry, it's too much for me to get into right now.
>
> But this should probably be implemented in show-paren-mode. Please file a
> separate bug with this feature request.
>
> And please clarify: the way it works now, are you going to use
> `jump-offscreen'? If not, I'm going to revert that commit.

Please don't revert it! This is very useful feature (make sure it is
mentioned in the docs).

“As is”, this is already very good thing that works flawlessly until you
activate ‘show-paren-mode’. I will send separate bug report, I hope this
will work fine in combination with that mode.

Thanks.

bug#21286: 25.0.50; Setting ‘blink-matching-delay’ has no effect

[Dmitry Gutov]

On 08/19/2015 03:27 PM, Mark Karpov wrote:

> Please don't revert it! This is very useful feature (make sure it is
> mentioned in the docs).

It's mentioned.

> “As is”, this is already very good thing that works flawlessly until you
> activate ‘show-paren-mode’. I will send separate bug report, I hope this
> will work fine in combination with that mode.

My point is, the relevant show-paren-mode behavior will most likely be 
predicated on a different variable.

So that latest change (that I would revert) won't help it in the least.