unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20871@debbugs.gnu.org
Subject: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren
Date: Sat, 30 Apr 2016 14:26:28 +0200	[thread overview]
Message-ID: <87vb2zth8r.fsf@mbork.pl> (raw)
In-Reply-To: <838tzvpcjb.fsf@gnu.org>


On 2016-04-30, at 13:21, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Marcin Borkowski <mbork@mbork.pl>
>> Cc: 20871@debbugs.gnu.org
>> Date: Fri, 29 Apr 2016 14:18:34 +0200
>> 
>> >> +    (looking-at "[^[:alpha:]][[:alpha:]]")))
>> >
>> > You should be aware that starting with Emacs 25.1 [:alpha:] matches a
>> > very large class of characters, some of them having nothing in common
>> > with those used in Polish.  So perhaps it is better to use '\cl'
>> > instead, which will only capture Latin characters?  Just a thought --
>> > your call.
>> 
>> I guess you are right, Eli - in fact, all one-letter words in Polish are
>> matched by [aiouwz].  I decided to go with \cl, as you suggested,
>> though - this way, the function could be (probably) useful also for
>> Slovaks, for instance.  I attach the corrected patch.
>
> LGTM, thanks.

Thanks!

>> Just to be sure: in my Emacs, \cl matches also ą, ę, ż, ź, á, ö etc.  Is
>> it intentional?
>
> Yes.  \cl matches any character that belongs to any of the Latin
> blocks.
>
>> Is it documented somewhere?
>
> Not sure what needs to be documented, please elaborate.

Well, at first I thought that "Latin" means "matching [a-z]".  Finding
out that accented letter qualify, too, was a (pleasant) surprise.
Finding that out using `describe-categories' is a bit tricky, since its
output contains ranges, and I don't know which of them does e.g. "ą"
belong to.  The output of `describe-categories' says "Legend of category
mnemonics (see the tail for the longer description)"; I guess the
"longer" description might say something more.  For instance, this line:

(define-category ?l "Latin")

in characters.el

could be replaced by

(define-category ?l "Latin
Latin letters (including those with diacritics)")

This way, there would be at least a hint at the bottom of the *Help*
buffer displayed by `describe-categories'.

WDYT?  Would you like me to prepare a patch?

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University





  reply	other threads:[~2016-04-30 12:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 10:19 bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Marcin Borkowski
2015-06-22 10:28 ` Marcin Borkowski
2016-04-17  6:34   ` Marcin Borkowski
2016-04-17 14:57     ` Eli Zaretskii
2016-04-17 15:34       ` Marcin Borkowski
2016-04-17 16:49         ` Eli Zaretskii
2016-04-17 17:41           ` Marcin Borkowski
2016-04-27  7:02           ` Marcin Borkowski
2016-04-27  7:20             ` Eli Zaretskii
2016-04-29 12:18               ` Marcin Borkowski
2016-04-30 11:21                 ` Eli Zaretskii
2016-04-30 12:26                   ` Marcin Borkowski [this message]
2016-04-30 12:38                     ` Eli Zaretskii
2016-04-30 16:41                       ` Marcin Borkowski
2016-04-30 17:01                         ` Eli Zaretskii
2016-04-30 18:42                           ` Marcin Borkowski
2016-04-30 19:01                             ` Eli Zaretskii
2017-12-07 13:28                               ` Marcin Borkowski
2017-12-09 11:52                                 ` Eli Zaretskii
2017-12-09 15:45                                   ` Marcin Borkowski
2017-12-19 11:44                                     ` Marcin Borkowski
2017-12-19 16:15                                       ` Eli Zaretskii
2018-01-02  8:55                                         ` Marcin Borkowski
2018-01-13  8:46                                           ` Eli Zaretskii
2018-01-13 16:01                                             ` Marcin Borkowski
2018-01-13 16:53                                               ` Eli Zaretskii
2018-01-13 17:02                                                 ` Eli Zaretskii
2018-01-15  5:13                                                   ` Marcin Borkowski
2018-01-15  5:13                                                 ` Marcin Borkowski
2018-01-15  5:30                                                   ` Marcin Borkowski
2018-01-15 13:07                                                     ` Eli Zaretskii
2018-01-24  9:34                                                       ` Marcin Borkowski
2018-01-24 19:16                                                         ` Eli Zaretskii
2016-04-30 17:42                         ` Drew Adams
2016-04-30 18:24                           ` Eli Zaretskii
2016-04-30 18:41                             ` Marcin Borkowski
2018-02-02  9:18       ` Michal Nazarewicz
     [not found] <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org>
     [not found] ` <8336i1p8zd.fsf@gnu.org>
     [not found]   ` <CA+pa1O3rcDznoR0u8i_AN5iHe9mM+FHqkAO=yVM2Gu5_Gc40jQ@mail.gmail.com>
2019-08-17  6:57     ` Eli Zaretskii
2019-08-17 14:17       ` Marcin Borkowski
2019-08-17 15:04         ` Eli Zaretskii
2019-08-17 15:58           ` Marcin Borkowski
2019-08-19 14:07       ` Michał Nazarewicz
2019-08-19 15:01         ` Eli Zaretskii
2019-08-19 15:36           ` Michał Nazarewicz
2019-08-19 16:16             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb2zth8r.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=20871@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).