From: phillip.lord@russet.org.uk (Phillip Lord)
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, 23785@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#23785: Emacs 25: 'Undo' overdoes things.
Date: Tue, 21 Jun 2016 15:30:46 +0100 [thread overview]
Message-ID: <87vb12ty09.fsf@russet.org.uk> (raw)
In-Reply-To: <83fus67kap.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Jun 2016 16:17:50 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Cc: monnier@iro.umontreal.ca, acm@muc.de, 23785@debbugs.gnu.org
>> Date: Mon, 20 Jun 2016 18:12:29 +0100
>>
>> >> From: phillip.lord@russet.org.uk (Phillip Lord)
>> >> Cc: "Eli Zaretskii" <eliz@gnu.org>, acm@muc.de, 23785@debbugs.gnu.org
>> >> Date: Mon, 20 Jun 2016 16:03:35 +0100
>> >>
>> >> My suggestion: this patch goes to Emacs-25.
>> >
>> > What patch?
>>
>> Eli, do pay attention! The one that I didn't attach obviously.
>
> Thanks, please push to the emacs-25 branch, with one change:
>
>> + /*
>> + Temporarily enable the undo-buffer to ensure that the change
>> + is marked as an undoable one. Bug #23785.
>> + */
>
> Please format this comment according to our style.
Okay. Stefan, can you have a quick look as well. This function is well
out of my depth of understanding.
Phil
next prev parent reply other threads:[~2016-06-21 14:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:02 bug#23785: Emacs 25: "Undo" overdoes things Alan Mackenzie
2016-06-17 17:15 ` Eli Zaretskii
2016-06-17 17:45 ` Alan Mackenzie
2016-06-17 20:07 ` Eli Zaretskii
2016-06-17 21:47 ` Phillip Lord
2016-06-18 4:46 ` Stefan Monnier
2016-06-18 7:54 ` Eli Zaretskii
2016-06-18 18:42 ` Stefan Monnier
2016-06-18 19:02 ` Eli Zaretskii
2016-06-18 19:52 ` Stefan Monnier
2016-06-19 22:45 ` bug#23785: Emacs 25: 'Undo' " Phillip Lord
2016-06-20 0:59 ` Stefan Monnier
2016-06-20 12:47 ` Phillip Lord
2016-06-20 14:04 ` Stefan Monnier
2016-06-20 15:03 ` Phillip Lord
2016-06-20 15:34 ` Eli Zaretskii
2016-06-20 17:12 ` Phillip Lord
2016-06-21 13:17 ` Eli Zaretskii
2016-06-21 14:30 ` Phillip Lord [this message]
2016-06-21 21:25 ` Stefan Monnier
2016-06-21 22:08 ` Phillip Lord
2020-09-04 14:03 ` Lars Ingebrigtsen
2020-09-05 13:15 ` Alan Mackenzie
2016-06-21 13:18 ` Eli Zaretskii
2016-06-21 14:29 ` Phillip Lord
2016-06-21 16:13 ` Eli Zaretskii
2016-06-17 21:23 ` bug#23785: Emacs 25: "Undo" " Phillip Lord
2016-06-18 17:41 ` Alan Mackenzie
2016-06-17 21:49 ` Óscar Fuentes
2016-06-20 12:33 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb12ty09.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=23785@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).