From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23159: 24.5; --eval bug Date: Sun, 03 Jul 2016 14:54:32 -0400 Message-ID: <87vb0meemv.fsf@users.sourceforge.net> References: <83r3esugqx.fsf@gnu.org> <87shvrftqq.fsf@users.sourceforge.net> <8DC20D82-8837-445D-B32E-30726B694263@jovi.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1467572126 22511 80.91.229.3 (3 Jul 2016 18:55:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2016 18:55:26 +0000 (UTC) Cc: Devon Sean McCullough , 23159@debbugs.gnu.org To: Devon Sean McCullough Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 03 20:55:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJmXy-0002q0-U9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 20:55:15 +0200 Original-Received: from localhost ([::1]:43766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJmXy-00040H-1G for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 14:55:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJmXq-0003yH-J6 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 14:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJmXm-0001go-E0 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 14:55:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJmXm-0001gk-AH for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 14:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJmXm-0006rD-2e for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 14:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2016 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23159 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23159-submit@debbugs.gnu.org id=B23159.146757207226304 (code B ref 23159); Sun, 03 Jul 2016 18:55:02 +0000 Original-Received: (at 23159) by debbugs.gnu.org; 3 Jul 2016 18:54:32 +0000 Original-Received: from localhost ([127.0.0.1]:36172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJmXH-0006qC-Og for submit@debbugs.gnu.org; Sun, 03 Jul 2016 14:54:31 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:38472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJmXG-0006pz-EM for 23159@debbugs.gnu.org; Sun, 03 Jul 2016 14:54:30 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id h190so51095238ith.1 for <23159@debbugs.gnu.org>; Sun, 03 Jul 2016 11:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lxSoHSXGlktq8gUQTyJYBAWwAarPcCNb9zY9YyKPfcA=; b=IqbLRh3rSGuOET3xum/5uVSxcMJMAXAPVT5mSM76xE+xIc43wl0fNEfCC6R6JJb2RJ lwu7Bqnm+80U5O+i/jLq/2gK1J+rGlceiAEz9xwq2+mFjQkszMBjiZnS/8aPQDVZX853 SYXeimwb+5r1/DRv0pkdqZYlUbzsuexwxAHoVDsUegzNZoP/KCJZqCJ5HTO75TMK+zX8 m8OpCLQCYsjThH4OUlgRi1ezuKtm3wmVArPGZ69o6Gfx6a2e5gjmupykrG/F18o53dCS LRYOO9VOfRqX7nwoT07MW4MlhxTNx8pn6Fm9AdIMiCGsh9LIxGn6NpWErScGSi0zdCF8 jORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=lxSoHSXGlktq8gUQTyJYBAWwAarPcCNb9zY9YyKPfcA=; b=bsib47d/qLoHTa8nZ7DW0uZ9W3EjISgI+IvuxuFOPl1MMHjVtxcMFbdoVtSMfZKyXR lyc/xTEIirzHrFjUZ7J/HLMIOZFgBD1Yn/yw2D05XJ21Fyqjk9MpMpPlQr0FpxLaOn5Y 9qu28HYi3Z7BAXgjULyikWJhBUnFmSRBBUrdYYi6SWNlyCCCW41kkNl+V0zBhVmxRy6X aI6l/uKXdB1asdh785R43lPvo1hfJlnpCdn1C0ititAeLVfFzBaIrccI7H6da9MHQF0S OZBjp0j0LOTLw2rko9f9N6kC3NC0dsEi74kyQ+PR6JvzmiSMjYfdK6r4zH101fx0TK8i O7CQ== X-Gm-Message-State: ALyK8tI1302ajV5CJv4ojGLAKX+LfN2y/QVpDLyD7jb7LYIYxOLHx9p81HbqgaO/Aswzrg== X-Received: by 10.36.10.204 with SMTP id 195mr6335335itw.93.1467572064897; Sun, 03 Jul 2016 11:54:24 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id g11sm225130iod.41.2016.07.03.11.54.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jul 2016 11:54:24 -0700 (PDT) In-Reply-To: <8DC20D82-8837-445D-B32E-30726B694263@jovi.net> (Devon Sean McCullough's message of "Sun, 3 Jul 2016 06:25:06 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120356 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Devon Sean McCullough writes: > I=E2=80=99d suggest (error "Trailing garbage following expression=E2=80= =9D) > for consistency with the eval-expression function. Makes sense. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Warn-if-eval-arg-has-text-beyond-1-expression.patch Content-Description: patch-v2 >From 5990021e37069a8a03181dc5167f0e94d748981e Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 2 Jul 2016 20:26:35 -0400 Subject: [PATCH v2] Warn if --eval arg has text beyond 1 expression * lisp/startup.el (command-line-1): If --eval argument has more data than constitutes a single Lisp expression, print warning (Bug #23159). --- lisp/startup.el | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lisp/startup.el b/lisp/startup.el index 761e69e..75ae9f9 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -2360,7 +2360,15 @@ command-line-1 ((member argi '("-eval" "-execute")) (setq inhibit-startup-screen t) - (eval (read (or argval (pop command-line-args-left))))) + (let* ((str-expr (or argval (pop command-line-args-left))) + (read-data (read-from-string str-expr)) + (expr (car read-data)) + (end (cdr read-data))) + (eval expr) + (unless (= end (length str-expr)) + (lwarn '(command-line eval) :warning + "Trailing garbage following expression: %s" + (substring str-expr end))))) ((member argi '("-L" "-directory")) ;; -L :/foo adds /foo to the _end_ of load-path. -- 2.8.0 --=-=-=--