From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24633: highlight-region func using (window-hscroll) in :align-to spec can cause inf loop Date: Sat, 22 Oct 2016 16:43:54 -0400 Message-ID: <87vawkru5x.fsf@users.sourceforge.net> References: <87vax5vuoj.fsf@users.sourceforge.net> <834m4nhz1t.fsf@gnu.org> <874m4mwyj2.fsf@users.sourceforge.net> <837f9ihg8l.fsf@gnu.org> <87y41yved9.fsf@users.sourceforge.net> <83y41yfwam.fsf@gnu.org> <87lgxxvh6o.fsf@users.sourceforge.net> <83h98lg0cn.fsf@gnu.org> <87y41grxox.fsf@users.sourceforge.net> <83inskp3wq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477169066 19503 195.159.176.226 (22 Oct 2016 20:44:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Oct 2016 20:44:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24633@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 22 22:44:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1by39G-0003Ho-5G for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Oct 2016 22:44:10 +0200 Original-Received: from localhost ([::1]:38626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1by39I-0003Eg-Ap for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Oct 2016 16:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1by39B-0003DU-5P for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 16:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1by398-0003kd-30 for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 16:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1by397-0003kL-WA for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 16:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1by397-0007zt-Nw for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 16:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2016 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24633-submit@debbugs.gnu.org id=B24633.147716900330690 (code B ref 24633); Sat, 22 Oct 2016 20:44:01 +0000 Original-Received: (at 24633) by debbugs.gnu.org; 22 Oct 2016 20:43:23 +0000 Original-Received: from localhost ([127.0.0.1]:46630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1by38V-0007yq-Hw for submit@debbugs.gnu.org; Sat, 22 Oct 2016 16:43:23 -0400 Original-Received: from mail-qk0-f170.google.com ([209.85.220.170]:32820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1by38T-0007yX-Sa; Sat, 22 Oct 2016 16:43:22 -0400 Original-Received: by mail-qk0-f170.google.com with SMTP id n189so193647410qke.0; Sat, 22 Oct 2016 13:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aIb+fuYQqHQPDq26MfU/A4rkfptNmzKeilDoi5Zombs=; b=zKdhMLxKfuK1hkHDrnfPsnG5GuOaVQg3SwBFu4HEuX6iz3w2wbHgQYijq9iQTodgjm 2FEMeui/82pnezblx/itGrNDEMNl/+HtGhWCuXVscK6/FzQYen6+CCsR2PtzK+M5/+Ou N5QtM3266Kja4qALTUsQF0kjP1uYq10f0+BYsnLrQq6S2kz5Cs7briz6hXwNl9w2tzX4 Ko1varp/LQGF1arb6qTHf7GmLaH0/sVVU+vrSxhm/jKpj9keIpk7eF1nV6fjDXSGGQsK rP4iyh3U/0C2MkpNIoovf754DOwvRxSwlUU9him5Jo7eKbdf4F/R6OLkI+O6ebIweDa/ Aq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=aIb+fuYQqHQPDq26MfU/A4rkfptNmzKeilDoi5Zombs=; b=eHNCYP8e/KzacKgtB/WGgNmasrA1TcHOZ7LBhvUOaHGgtECniy9pQnbCC6y5Uj9KSh os/v4b3KGdREehA0AoWo8P+E3TJkG3O055uzKbdqVCoEc5pMw8yUdTTZTUxCiN4WQic+ hQ8WkUrunV+bpS+YMPFNU4noUl8xsy66feiwoZB/RMfQu2EQ8xsCsmNnBwtr976lNd9W YOWB9mDHZPQ6q72rhYs7xJin4Mbm1e1XzoIDcLRfBYkNf9bNy1bTvA6KSIjimfhpH+q+ Pq/DANGPPSd4NaS6PBwyBSjaujeGQ/eAINGcTu6LGVkuX4TSaAS4I2rwax4/ZQzkl2aj i6FA== X-Gm-Message-State: ABUngvfZ7xEEZqv1Vo2wWBuNFMb9zEdVXa4FQ1PjWLVDtl46HNmX5eSftN77pHlIUro20Q== X-Received: by 10.55.133.198 with SMTP id h189mr8809183qkd.104.1477168996388; Sat, 22 Oct 2016 13:43:16 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id b83sm4614221qkc.42.2016.10.22.13.43.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Oct 2016 13:43:15 -0700 (PDT) In-Reply-To: <83inskp3wq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Oct 2016 22:41:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124856 Archived-At: tags 24633 fixed close 24633 26 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Cc: 24633@debbugs.gnu.org >> Date: Sat, 22 Oct 2016 15:27:42 -0400 >> >> I tried adding a counter in redisplay_internal, it prevents having a >> tight loop in C. Actually, the behaviour becomes like the split window >> case: there is additional hscrolling each time the cursor blinks, but it >> can be interrupted with C-g. That seems adequate behaviour to me, what >> do you think? > > Did you see what happens when blink-cursor-mode is turned off? (If > that's what you meant by "each time the cursor blinks; if not, what > caused it to blink?) If I turn blink-cursor-mode off, then it stops scrolling after what seems like immediately (though I can see from the message calls that the highlight-region function was called several times). So the counter is limiting redisplay looping as expected. > > The patch looks OK to me, so if it gives better results than locking > up Emacs with the current code, let's push it to master. Okay, pushed as 241ae7a1 "Avoid infinite hscrolling in redisplay", and closing the bug as fixed.