From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#25158: [PATCH] A better way for test code to access messages Date: Tue, 07 Feb 2017 21:46:57 +0100 Message-ID: <87vasl91a6.fsf@gmx.de> References: <83fuju89rq.fsf@gnu.org> <87shns7pe6.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486500499 14978 195.159.176.226 (7 Feb 2017 20:48:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Feb 2017 20:48:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25158-done@debbugs.gnu.org, Gemini Lasswell To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 07 21:48:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbCgJ-0003Hv-O9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Feb 2017 21:48:07 +0100 Original-Received: from localhost ([::1]:56311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbCgP-0000v3-Bc for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Feb 2017 15:48:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbCgI-0000uy-12 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 15:48:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbCgE-0006N2-T6 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 15:48:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbCgE-0006My-PP for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 15:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cbCgE-0002mL-GZ for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2017 15:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2017 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25158-done@debbugs.gnu.org id=D25158.148650042810618 (code D ref 25158); Tue, 07 Feb 2017 20:48:02 +0000 Original-Received: (at 25158-done) by debbugs.gnu.org; 7 Feb 2017 20:47:08 +0000 Original-Received: from localhost ([127.0.0.1]:59332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbCfM-0002lC-IW for submit@debbugs.gnu.org; Tue, 07 Feb 2017 15:47:08 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:62466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbCfL-0002ki-Jg for 25158-done@debbugs.gnu.org; Tue, 07 Feb 2017 15:47:08 -0500 Original-Received: from detlef.gmx.de ([93.197.210.63]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MK0Np-1ccaF52Whh-001UCu; Tue, 07 Feb 2017 21:46:58 +0100 In-Reply-To: <87shns7pe6.fsf@gmx.de> (Michael Albinus's message of "Sun, 05 Feb 2017 14:12:17 +0100") X-Provags-ID: V03:K0:sU1r9brbdPrbLYsjKhEtBZfxte/BOHjxSf2mdBQYEpRFVDUsrhK SKMEJT3OH5YY48xD+fGxylaCcq605EpXJ4TIAsCaW/LQzenTFA1Dm3Pf63KVPxNeVVLWZix deE0RKkv+PuiuyWuyIplRX10D0oxPoIZMvThLWd1Iq+drX2GiFi5Hzxt+V+bpYvNmjl/A8l Qo35zQPtk2BX5755l/xhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/8TPmH9++zU=:rYUHKjBEYTy8jjUB59MiJy lmDja2YdzHjIqU/3JiTqhdiZi3W6cgcz5W7lF7cFe3bqLEAFfrg/WrG+o6qC7HvKbcLhDneZY C9GmRV1CP7bgBV/LqPlHzJFSduoUMH09D+AyPpZgI9CN0f2aIaMIK5dX+LAfP9YgPFY9vGNXY eYSZG1q1+vV6WBjTndYFuEhOY51wgY7NKA3YVwZ7vtha2UZzhIhYy6GjbgXSAOSGKPE3YIhGD ymyrHZ55izWIDDRoQoGe7P0SG8MAVDIgJuWdII54NPtfVQmLDrZDKg44PeNaQsPLv/uQE1rZS ZkaR14JGkGHrijx3x9YIFoVBj7ET1D5cH8P4DI1+hp+CAxJ3/9abxgbfwC1kJOJjiA2aqrHgb 51AYN5IKkvCJehAySAuhzlT3S9NmeVd9EGfHtK5DgovzBYydAesJ/UDkrOBq4HeKpUgiYzeBv xrZz9ER1Bs65pL2QzcJpzpLydfyxSNSCNXjG0LTuRmx+l/arskBNdYC7VqQ5HKKSACyTqaY0t HR4B1jj8hoEBSNFNRMdiYWaVGY9kQczKbVWbOizEPLcz46f4UkDyuvzpbW70H8qN+59Kp9xkn cU7jX/APzrnCccExzTZZ4jGdR3Mifi0IVCWaJ6j3sA4Bx7u+S0bJoKXvKoreh4Lzfl3cmKsBu QqsMoKb2yvC0Jou3tPsIR/8bM3lE4k1BHyaTvzS3aWeDSxHwg+RogT3q3ZsTuzqLGiUte+EqM hFUkoXKoIq2bGVOBEPizJQoYdylJU5deuS2mpq5OKTzKGSMiLL+xgWs6uSdnmQCkvnzrVn23 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129100 Archived-At: Michael Albinus writes: > Eli Zaretskii writes: > >> Making these changes didn't introduce any regressions in the relevant >> tests, so I pushed them. > > There is a new error when running under GNU/Linux from a shell: > > # make SELECTOR=\'file-notify-test03-autorevert-remote -C test filenotify-tests > [...] > Testing lisp/filenotify-tests.el > Running 1 tests (2017-02-05 11:42:33+0100) > > > Reverting buffer `file-notify-test141896xu'. > > Error: (wrong-type-argument stringp nil) > Reverting buffer `file-notify-test141896xu'. > > Error: (wrong-type-argument stringp nil) > passed 1/1 file-notify-test03-autorevert-remote > > The test passes, but the error message looks suspicious. I've tried to > find where it comes from, and it seems to be the new macro > `ert-with-message-capture'. I didn't debug further; maybe Gemini could > have a look? > > The bug is not visible when running the test interactively. Finally, it is not a bug of `ert-with-message-capture'. It comes from `vc-refresh-state', and it was not visible before using the new macro. I've adapted the test case `file-notify-test03-autorevert'; it works fine now. Bug#25158 could be closed. >> Thanks. Best regards, Michael.