From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Fri, 28 Apr 2017 22:17:33 -0600 Message-ID: <87vapn3l0i.fsf@tromey.com> References: <87mvefh8br.fsf@tromey.com> <1485375833.1960.0@smtp.gmail.com> <1485455113.4245.1@smtp.gmail.com> <1487359774.1998.0@smtp.gmail.com> <1488653191.6153.0@smtp.gmail.com> <1488738524.13864.0@smtp.gmail.com> <871str3b48.fsf@tromey.com> <1490812056.14782.1@smtp.gmail.com> <1492873665.3376.0@smtp.gmail.com> <87lgqpyl6y.fsf@pokyo> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493439498 31430 195.159.176.226 (29 Apr 2017 04:18:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Apr 2017 04:18:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25525@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 29 06:18:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4Jph-0007zH-6V for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Apr 2017 06:18:09 +0200 Original-Received: from localhost ([::1]:39803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4Jpm-00051Z-C6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Apr 2017 00:18:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4Jpe-00051T-6N for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 00:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4Jpb-0000U5-2G for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 00:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4Jpa-0000U1-QD for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 00:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d4Jpa-00028z-EI for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 00:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Apr 2017 04:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.14934394728225 (code B ref 25525); Sat, 29 Apr 2017 04:18:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 29 Apr 2017 04:17:52 +0000 Original-Received: from localhost ([127.0.0.1]:45362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4JpQ-00028b-1I for submit@debbugs.gnu.org; Sat, 29 Apr 2017 00:17:52 -0400 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:54997) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1d4JpN-00028K-T7 for 25525@debbugs.gnu.org; Sat, 29 Apr 2017 00:17:50 -0400 Original-Received: (qmail 20952 invoked by uid 0); 29 Apr 2017 04:17:38 -0000 Original-Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy7.mail.unifiedlayer.com with SMTP; 29 Apr 2017 04:17:38 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id E4Ha1v00H2f2jeq014HdHS; Fri, 28 Apr 2017 22:17:38 -0600 X-Authority-Analysis: v=2.2 cv=Ibz3YSia c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=AZ1AqLNKeXhY4gl7ilYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IX6G6vXW+AwpxDZ8+SYmhvYWlcUD7dqRuDvAMb5M06M=; b=A/t8G4WlpLJbGsuYIiLQnD5hB/ v6O2b7kWAt7pJg+U5vbeStMw1vUSbxd4FIK0UbPxb/SCdF0MMeDYZLfTqx7iuvJ/cGzevPUHH8TUq wkHhUS8zoEZngHYYGRgOf82GG; Original-Received: from 75-166-63-71.hlrn.qwest.net ([75.166.63.71]:58166 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1d4Jp8-0002w0-Me; Fri, 28 Apr 2017 22:17:34 -0600 X-Attribution: Tom In-Reply-To: <87lgqpyl6y.fsf@pokyo> (Tom Tromey's message of "Mon, 24 Apr 2017 07:44:21 -0600") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.63.71 X-Exim-ID: 1d4Jp8-0002w0-Me X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-63-71.hlrn.qwest.net (bapiya) [75.166.63.71]:58166 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132091 Archived-At: Tom> I finally was, I will look into it soon. Thanks again. This patch on top of my current patch was enough. However I'm not sure it is the best way. It does pass the css mode tests, but I'm also not sure that is sufficient. Could you try it out? Tom diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 9584bd2..2c81710 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -1506,7 +1506,8 @@ scss-mode-syntax-table (modify-syntax-entry ?/ ". 124" st) (modify-syntax-entry ?\n ">" st) ;; Variable names are prefixed by $. - (modify-syntax-entry ?$ "'" st) + (modify-syntax-entry ?$ "_" st) + (modify-syntax-entry ?% "_" st) st)) (defun scss-font-lock-keywords ()