From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24402: should-error doesn't catch all errors Date: Sun, 16 Jul 2017 20:46:02 -0400 Message-ID: <87vamrc2lx.fsf@users.sourceforge.net> References: <3654D8E9-D3CB-402B-922F-B132C1871E9F@runbox.com> <596E65D2-E780-43A1-A75B-603B61B6F9F4@runbox.com> <87zickhoco.fsf_-_@lylat> <877eznda7v.fsf@lylat> <874lur0zki.fsf@calancha-pc> <87o9sywtbz.fsf@lylat> <87fue3f9p8.fsf@users.sourceforge.net> <87vamyl3j3.fsf@lylat> <87tw2het1b.fsf@users.sourceforge.net> <874luhbo4l.fsf@lylat> <87lgntdswo.fsf@users.sourceforge.net> <87k23d9gvt.fsf@lylat> <87d195dmr0.fsf@users.sourceforge.net> <87lgns7y7g.fsf@lylat> <877ezbew3d.fsf@users.sourceforge.net> <87d193ljdp.fsf@lylat> <87shhxcqit.fsf@users.sourceforge.net> <87inithwi5.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500252350 20664 195.159.176.226 (17 Jul 2017 00:45:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Jul 2017 00:45:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Gemini Lasswell , 24402@debbugs.gnu.org, Tino Calancha To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 17 02:45:42 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWuAQ-0004qy-DX for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jul 2017 02:45:42 +0200 Original-Received: from localhost ([::1]:47364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWuAT-0007fl-0n for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jul 2017 20:45:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWu9r-0007M9-Hh for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2017 20:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWu9m-0006m1-MY for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2017 20:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWu9m-0006le-Je for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2017 20:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dWu9l-0003dt-NA for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2017 20:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2017 00:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24402-submit@debbugs.gnu.org id=B24402.150025227613951 (code B ref 24402); Mon, 17 Jul 2017 00:45:01 +0000 Original-Received: (at 24402) by debbugs.gnu.org; 17 Jul 2017 00:44:36 +0000 Original-Received: from localhost ([127.0.0.1]:42898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWu9M-0003cw-99 for submit@debbugs.gnu.org; Sun, 16 Jul 2017 20:44:36 -0400 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:32909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWu9K-0003ck-Lv for 24402@debbugs.gnu.org; Sun, 16 Jul 2017 20:44:35 -0400 Original-Received: by mail-io0-f170.google.com with SMTP id h64so35751163iod.0 for <24402@debbugs.gnu.org>; Sun, 16 Jul 2017 17:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Wux290nuf+TGHiCq/c7IYJG1Tkw1QOUoI7X0k9vAsOk=; b=SCk6tI1xnnfvApK3EUqbSh9VAIqnQE1aQAch2hjDTjyAxLCMaIZKe3T6g6FW2uaCPB jYVHovg3L8yZjUYI58VoT4uflD/4Oi5fp+LdBd6cxTnI+1GYN13un8CPxSx8ndGFG5ov 1Ccw25MlK6DKYCwubkH5fP2gqM7JsBE2Fj37HaEiL4DLba1TTfNswjLndghtYMR9ysF3 da3AtvdZf3ruX1qbT0eX4B+5Y6oGq7On0j2eS9BxLqLVBHHa6spfZNvdmDEC2fQOkOdQ 337Q6j7zIwE0SMAlYy5ENqLtOkCP9TvTf3bhlJssx/+f4vGP0r5zaLLbKgKDdmJqo62B t3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Wux290nuf+TGHiCq/c7IYJG1Tkw1QOUoI7X0k9vAsOk=; b=dBAdkr36+mGqA89j22fgLNevxp0eKgVvbGj6VrLHs5PfWwi1iU96YkhgPQuyP/xfeg EK+pom8TEdj5HTUMaSdaq/zWI4ZWKBq9re21/wyi/Q8uvN9PQWyyWUyASVIhhltHCXLP 9n2Tss+ucfytL123G9/DSzETQffhB/OpeWXtySYkMJtTN2tpnTil9DzEUHo5HhabaSVc 1ePw0zhKGFHJ2WBr4cIrbc4+DiNezRXlscO6AXZKp/vvSlKT1vSag8BVFbT+24RVLQct 8sLjNKRmE+wCrODiQARf8Zq3lWNO3UbXBmDtqwXZsLq2S7+UluS/Nd/trnJxDN02QqP8 f9cg== X-Gm-Message-State: AIVw110TIPbmAOMM3jDnC28h8Nlpso07fNkx4MY0Oic3XNiJMQ9p3Kw6 GoMYCepbXLlH7g== X-Received: by 10.107.173.15 with SMTP id w15mr16375077ioe.99.1500252269085; Sun, 16 Jul 2017 17:44:29 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 189sm4864167itl.11.2017.07.16.17.44.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jul 2017 17:44:28 -0700 (PDT) In-Reply-To: <87inithwi5.fsf@lylat> (Alex's message of "Sat, 15 Jul 2017 21:49:06 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134645 Archived-At: Alex writes: > Oddly enough, I can't reproduce this on master. I cloned a new copy, ran > "./autogen.sh && ./configure && make -j4", then ran "make eieio-tests > TEST_LOAD_EL=no" with no error. I cloned from 30444c695, then tried > again with 7a0fb008. I also tried "make check-expensive TEST_LOAD_EL=no" > and got only 2 errors (dom-tests and cl-lib-tests). > > Perhaps odder is that I can still reproduce your recipe in Bug#27718 in > that same repository. Uh, actually, now I'm getting the same results as you (i.e., make eieio-tests TEST_LOAD_EL=no passes on master for me, though the #27718 test case does fail). Perhaps I accidentally ran an eieio-tests.elc file produced by a patched Emacs using a non-patched Emacs before? >> I have a fix for the subr-tests failed, as for the others, I don't know >> enough about the compilation process to untangle it yet. I think we >> should just leave the inline-function expansion part out for now, at >> which point I believe your patch won't be making anything worse, so it >> should be okay to install. > > Sounds good. It would be lucky if a fix to Bug#27718 also resolves the > other inline function errors so that we could use the previous patch. > Here's an updated patch with inline function excluded: Okay, so the patch does make a couple more tests fail, but I think it's actually an improvement since #27718 shows that the scenario was already failing outside of ert-deftest, i.e., in this case your patch is making code inside the test more like code outside the test. We can just mark those as expected failures when compiled. I will merge to master in a few days, assuming there are no objections.