From: npostavs@users.sourceforge.net
To: Alex <agrambot@gmail.com>
Cc: Gemini Lasswell <gazally@runbox.com>,
24402@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#24402: should-error doesn't catch all errors
Date: Sun, 16 Jul 2017 20:46:02 -0400 [thread overview]
Message-ID: <87vamrc2lx.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87inithwi5.fsf@lylat> (Alex's message of "Sat, 15 Jul 2017 21:49:06 -0600")
Alex <agrambot@gmail.com> writes:
> Oddly enough, I can't reproduce this on master. I cloned a new copy, ran
> "./autogen.sh && ./configure && make -j4", then ran "make eieio-tests
> TEST_LOAD_EL=no" with no error. I cloned from 30444c695, then tried
> again with 7a0fb008. I also tried "make check-expensive TEST_LOAD_EL=no"
> and got only 2 errors (dom-tests and cl-lib-tests).
>
> Perhaps odder is that I can still reproduce your recipe in Bug#27718 in
> that same repository.
Uh, actually, now I'm getting the same results as you (i.e., make
eieio-tests TEST_LOAD_EL=no passes on master for me, though the #27718
test case does fail). Perhaps I accidentally ran an eieio-tests.elc
file produced by a patched Emacs using a non-patched Emacs before?
>> I have a fix for the subr-tests failed, as for the others, I don't know
>> enough about the compilation process to untangle it yet. I think we
>> should just leave the inline-function expansion part out for now, at
>> which point I believe your patch won't be making anything worse, so it
>> should be okay to install.
>
> Sounds good. It would be lucky if a fix to Bug#27718 also resolves the
> other inline function errors so that we could use the previous patch.
> Here's an updated patch with inline function excluded:
Okay, so the patch does make a couple more tests fail, but I think it's
actually an improvement since #27718 shows that the scenario was already
failing outside of ert-deftest, i.e., in this case your patch is making
code inside the test more like code outside the test. We can just mark
those as expected failures when compiled.
I will merge to master in a few days, assuming there are no objections.
next prev parent reply other threads:[~2017-07-17 0:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 1:26 bug#24402: 25.1.50; testcover-start breaks should-error Gemini Lasswell
[not found] ` <handler.24402.B.14734739098199.ack@debbugs.gnu.org>
2016-09-20 4:27 ` bug#24402: More Information Gemini Lasswell
2017-07-04 3:28 ` bug#24402: should-error doesn't catch all errors (Was:bug#24402: More Information) Alex
2017-07-05 0:00 ` bug#24402: should-error doesn't catch all errors Alex
2017-07-05 13:43 ` Tino Calancha
2017-07-05 19:56 ` Alex
2017-07-07 10:15 ` Tino Calancha
2017-07-09 7:04 ` Alex
2017-07-11 12:18 ` npostavs
2017-07-12 3:47 ` Alex
2017-07-12 12:30 ` npostavs
2017-07-12 16:45 ` Alex
2017-07-13 1:31 ` npostavs
2017-07-13 3:04 ` Alex
2017-07-13 3:44 ` npostavs
2017-07-13 22:45 ` Alex
2017-07-13 23:49 ` npostavs
2017-07-14 4:42 ` Alex
2017-07-14 4:45 ` Alex
2017-07-15 21:57 ` npostavs
2017-07-16 3:49 ` Alex
2017-07-17 0:46 ` npostavs [this message]
2017-07-19 21:23 ` Gemini Lasswell
2017-07-19 22:40 ` Alex
2017-07-19 23:04 ` npostavs
2017-07-20 4:04 ` Alex
2017-07-20 19:23 ` Gemini Lasswell
2017-08-08 1:15 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vamrc2lx.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24402@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=gazally@runbox.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).