From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27762: 26.0.50; ls-lisp: misalignment when dired-directory is a cons Date: Wed, 02 Aug 2017 00:08:02 +0900 Message-ID: <87vam78gx9.fsf@calancha-pc> References: <87wp75yuuh.fsf@calancha-pc> <83vamobboe.fsf@gnu.org> <87lgnjzs8d.fsf@calancha-pc> <87d18uz8w1.fsf@calancha-pc> <83shhf3brw.fsf@gnu.org> <87a83jkc02.fsf@calancha-pc> <834ltr1jvp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501600168 22592 195.159.176.226 (1 Aug 2017 15:09:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 15:09:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: 27762-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 01 17:09:24 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYnL-0005Eb-Es for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 17:09:15 +0200 Original-Received: from localhost ([::1]:43168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYnR-0008Gw-GF for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 11:09:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYnC-0008BA-Ov for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 11:09:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcYn9-00047t-6H for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 11:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcYn9-00047c-3l for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 11:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dcYn8-0007z2-Vm for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 11:09:02 -0400 Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2017 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 27762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 27762@debbugs.gnu.org, tino.calancha@gmail.com, tino.calancha@gmail.com Original-Received: via spool by 27762-done@debbugs.gnu.org id=D27762.150160009430604 (code D ref 27762); Tue, 01 Aug 2017 15:09:02 +0000 Original-Received: (at 27762-done) by debbugs.gnu.org; 1 Aug 2017 15:08:14 +0000 Original-Received: from localhost ([127.0.0.1]:37072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYmM-0007xY-6k for submit@debbugs.gnu.org; Tue, 01 Aug 2017 11:08:14 -0400 Original-Received: from mail-pf0-f181.google.com ([209.85.192.181]:33686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYmK-0007xJ-TJ for 27762-done@debbugs.gnu.org; Tue, 01 Aug 2017 11:08:13 -0400 Original-Received: by mail-pf0-f181.google.com with SMTP id d67so9017600pfc.0 for <27762-done@debbugs.gnu.org>; Tue, 01 Aug 2017 08:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=LABZzaCY53JOEioAEXj+GrBgpaE6/XO7hoSWgxij0FQ=; b=tFJ52asiZCdBcrJWbdIoAMhoTenvf7/49hzCPiAUCD2Zg49eZ3zZ+PYsmdrwKPdRI3 N/tLS6THNxJR4xMMWUbAeTq+Q3ywrNL5s4GAWbBYAavys2txWvPfU6xhnVrIWmzEWTQq ctLSkVLkJOSsqcTAE3lrPwZXqhsw/SrPPxkVL0qkMCXJ9b9gv1FVqWJW8RQdRGn4ctQ1 9yZWY2GRsunPFm1v7jRljEjT04MdZ8qFbH5gdaciJoPZLhCdmDU8V7RC/51Hr/dw+/9f iXb+s25T8JTqn3htSEdigIfD2VwUKDIH4IUeU8Va7q1gwYDYVBQEBjNjOXIzoiifsFqm JDew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LABZzaCY53JOEioAEXj+GrBgpaE6/XO7hoSWgxij0FQ=; b=ca0iyEfxeVjvjP97qPAQnWMdw/aI4fNUtFtrfkQxT8Gv9JigPD7rk8YTpAeWoZop9Z OF+xCTUy9DQaQlLO5kplQqmdXHMDlus/uYWDDKeM68IYGBUCN6SjtFoPIEGDqaiTZsIf Ka6GLWvbfmpuwvqnDQX6WYaHKyXHx6MApOa/irXMawUpeOHqgPnB0fKkOgDeu6JE8hmb jyXGMBlpzD/ihYnE8MmB6T3/6i129/NwfbvqNkQBhf7ZWMw9x0lDBO9Mmkg41cw4KNtK La5LwuhiItHK3a7ljC7hXoZqmi5LaznYpA5591dJyBYihGTn3L2+97SS+K4o8DZxv+MQ 4trA== X-Gm-Message-State: AIVw111Hfiz0m73RL9ZOO+F5LhKKiEBNsK419uhLgeIA941nSwzmyz+7 CBufYntfD3SvhoAV X-Received: by 10.99.146.2 with SMTP id o2mr15432827pgd.54.1501600086699; Tue, 01 Aug 2017 08:08:06 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id k26sm58104964pfb.145.2017.08.01.08.08.04 for <27762-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Aug 2017 08:08:05 -0700 (PDT) In-Reply-To: <834ltr1jvp.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 01 Aug 2017 16:46:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135216 Archived-At: Eli Zaretskii writes: >> From: Tino Calancha >> Cc: 27762@debbugs.gnu.org >> Date: Tue, 01 Aug 2017 16:01:17 +0900 >> >> Eli Zaretskii writes: >> >> > Looks OK, but why this complicated code: >> > >> >> + (when-let* ((col-diff (- (point) (point-at-bol))) >> >> + (higher (> col-diff target))) >> >> + (setq target col-diff))) >> >> + (and (/= first target) target)))) >> > >> > Doesn't current-column do its job in this case? >> That is to work regardless on the `dired-hide-details-mode' value. >> If we use `current-column' we are in trouble. > > Then (a) please mention this issue in a comment before this fragment, > and (b) please don't call the variable "column", because it's > confusing. a) The comment is right before the while loop. b) Done. Pushed into master as commit f74164a845eff579635da0a1267514ef9d040ad2