From: Tino Calancha <tino.calancha@gmail.com>
To: 27762-done@debbugs.gnu.org
Subject: bug#27762: 26.0.50; ls-lisp: misalignment when dired-directory is a cons
Date: Wed, 02 Aug 2017 00:08:02 +0900 [thread overview]
Message-ID: <87vam78gx9.fsf@calancha-pc> (raw)
In-Reply-To: <834ltr1jvp.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 01 Aug 2017 16:46:02 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Tino Calancha <tino.calancha@gmail.com>
>> Cc: 27762@debbugs.gnu.org
>> Date: Tue, 01 Aug 2017 16:01:17 +0900
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > Looks OK, but why this complicated code:
>> >
>> >> + (when-let* ((col-diff (- (point) (point-at-bol)))
>> >> + (higher (> col-diff target)))
>> >> + (setq target col-diff)))
>> >> + (and (/= first target) target))))
>> >
>> > Doesn't current-column do its job in this case?
>> That is to work regardless on the `dired-hide-details-mode' value.
>> If we use `current-column' we are in trouble.
>
> Then (a) please mention this issue in a comment before this fragment,
> and (b) please don't call the variable "column", because it's
> confusing.
a) The comment is right before the while loop.
b) Done.
Pushed into master as commit f74164a845eff579635da0a1267514ef9d040ad2
next prev parent reply other threads:[~2017-08-01 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 3:21 bug#27762: 26.0.50; ls-lisp: misalignment when dired-directory is a cons Tino Calancha
2017-07-19 17:04 ` Eli Zaretskii
2017-07-20 3:45 ` Tino Calancha
2017-07-21 4:55 ` Tino Calancha
2017-07-29 8:09 ` Eli Zaretskii
2017-08-01 7:01 ` Tino Calancha
2017-08-01 13:46 ` Eli Zaretskii
2017-08-01 15:08 ` Tino Calancha [this message]
2017-08-01 15:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vam78gx9.fsf@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=27762-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).