unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29157@debbugs.gnu.org, ambrevar@gmail.com
Subject: bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed"
Date: Sat, 25 Nov 2017 16:41:52 -0500	[thread overview]
Message-ID: <87vahyxcgv.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83tvxi6r78.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Nov 2017 22:25:47 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> How about checking for a set of arguments that is compatible with what
>> current-time-string accepts.
>
> Is it really possible to do that reliably?

Should be okay if we err on the side of current-time-string:

  (pcase (cl-list* (nth 0 args) (nth 1 args) (nthcdr 2 args)))
    (`(,(or (pred listp) (pred integerp))
       ,(or 'nil 't 'wall (pred stringp)))
     t))

> Or maybe you meant to catch errors signaled by current-time-string,

That's another possibility, it would be more precise.

> and invoke the external command then.  If so, I'd agree.  But we
> should then allow customization of the external command's name,
> because on Windows it will be something like 'gdate', to avoid calling
> the incompatible Windows shell's built-in (which also prompts
> interactively for input).

I'm not in front of a Windows box at the moment, but I thought a cmd.exe
builtin like that could only be invoked by doing calling "cmd /C date".





  reply	other threads:[~2017-11-25 21:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 11:37 bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed" Pierre Neidhardt
2017-11-05 13:58 ` Noam Postavsky
2017-11-05 14:16   ` Pierre Neidhardt
2017-11-23  3:13     ` Noam Postavsky
2017-11-23  6:55       ` Pierre Neidhardt
2017-11-23 12:59         ` Noam Postavsky
2017-11-23 16:26           ` Eli Zaretskii
2017-11-25 17:54             ` Pierre Neidhardt
2017-11-25 18:32               ` Michael Albinus
2017-11-25 18:35                 ` Pierre Neidhardt
2017-11-25 18:50               ` Noam Postavsky
2017-11-25 19:50                 ` Eli Zaretskii
2017-11-25 20:06                   ` Noam Postavsky
2017-11-25 20:25                     ` Eli Zaretskii
2017-11-25 21:41                       ` Noam Postavsky [this message]
2017-11-26  3:35                         ` Eli Zaretskii
2017-11-26  3:21                   ` John Wiegley
2017-11-26 15:35                     ` Eli Zaretskii
2017-11-26 21:44                       ` John Wiegley
2017-11-25 19:29               ` Eli Zaretskii
2017-11-25 19:36                 ` Pierre Neidhardt
2017-11-25 19:57                   ` Eli Zaretskii
2017-11-26  9:17                     ` Pierre Neidhardt
2017-11-26 15:53                       ` Eli Zaretskii
2017-11-26  3:21                 ` John Wiegley
2017-11-26 15:33                   ` Eli Zaretskii
2017-11-26 21:45                     ` John Wiegley
2017-11-27  3:32                       ` Eli Zaretskii
2017-12-21  8:17                         ` John Wiegley
2017-12-03 20:43         ` Noam Postavsky
2017-12-04  8:43           ` John Wiegley
2017-12-04 12:51             ` Noam Postavsky
2017-11-05 15:16   ` Andreas Schwab
2017-11-10  2:04     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vahyxcgv.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=29157@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).