* bug#22307: wildcards dir-locals causes significant build slow-down in some cases
[not found] <3hegdwake0.fsf@fencepost.gnu.org>
@ 2017-09-02 12:37 ` Eli Zaretskii
2017-09-03 1:10 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2017-09-02 12:37 UTC (permalink / raw)
To: Glenn Morris; +Cc: 22307
unblock 24655 by 22307
thanks
> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 04 Jan 2016 20:24:23 -0500
>
> Package: emacs
> Version: 25.0.50
>
> commit 2e8488858c (allow wildcards in dir-locals) caused a significant
> (~20%) build slow down in some cases.
>
> Ref thread:
> http://lists.gnu.org/archive/html/emacs-devel/2015-12/msg00636.html
Having read that thread, and given the one and a half years since the
original report, this doesn't look like a problem that should block
the release of Emacs 26.1.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#22307: wildcards dir-locals causes significant build slow-down in some cases
2017-09-02 12:37 ` bug#22307: wildcards dir-locals causes significant build slow-down in some cases Eli Zaretskii
@ 2017-09-03 1:10 ` Glenn Morris
2017-12-04 3:02 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2017-09-03 1:10 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 22307
Eli Zaretskii wrote:
> Having read that thread, and given the one and a half years since the
> original report, this doesn't look like a problem that should block
> the release of Emacs 26.1.
It was already reverted from the previous release branch because it
wasn't considered suitable for a release. Personally I think allowing
two dir-locals (as it is now) is just not a good idea; and it's not just
me, eg http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01581.html
Anyway, the plan was to improve it for 26:
We can also just revert it from the release branch for the moment,
and postpone it until emacs 26 while we settle on a preferred
interface/implementation.
Nothing's happened since then AFAIK.
But I don't have anything else to say on the issue.
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#22307: wildcards dir-locals causes significant build slow-down in some cases
2017-09-03 1:10 ` Glenn Morris
@ 2017-12-04 3:02 ` Glenn Morris
2017-12-04 3:38 ` Noam Postavsky
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2017-12-04 3:02 UTC (permalink / raw)
To: 22307
There's no interest in addressing this issue. Closing as wontfix.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#22307: wildcards dir-locals causes significant build slow-down in some cases
2017-12-04 3:02 ` Glenn Morris
@ 2017-12-04 3:38 ` Noam Postavsky
2017-12-04 15:15 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2017-12-04 3:38 UTC (permalink / raw)
To: Glenn Morris; +Cc: 22307
Glenn Morris <rgm@gnu.org> writes:
> There's no interest in addressing this issue. Closing as wontfix.
I was going to take a look at this for Emacs 27, improving build times
is of interest to me. Though the bug thread here is a bit unclear, it
talks about the wildcards being the problem, but then weren't the
general wildcards replaced with the more limited dir-locals-2 thing?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#22307: wildcards dir-locals causes significant build slow-down in some cases
2017-12-04 3:38 ` Noam Postavsky
@ 2017-12-04 15:15 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2017-12-04 15:15 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 22307
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sun, 03 Dec 2017 22:38:36 -0500
> Cc: 22307@debbugs.gnu.org
>
> Glenn Morris <rgm@gnu.org> writes:
>
> > There's no interest in addressing this issue. Closing as wontfix.
>
> I was going to take a look at this for Emacs 27, improving build times
> is of interest to me. Though the bug thread here is a bit unclear, it
> talks about the wildcards being the problem, but then weren't the
> general wildcards replaced with the more limited dir-locals-2 thing?
Feel free to reopen if you would like to work on this.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-04 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <3hegdwake0.fsf@fencepost.gnu.org>
2017-09-02 12:37 ` bug#22307: wildcards dir-locals causes significant build slow-down in some cases Eli Zaretskii
2017-09-03 1:10 ` Glenn Morris
2017-12-04 3:02 ` Glenn Morris
2017-12-04 3:38 ` Noam Postavsky
2017-12-04 15:15 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).