From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#29842: 27.0; `dired-change-marks': args should not be optional Date: Thu, 28 Dec 2017 22:18:06 +0900 Message-ID: <87vagr6lf5.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1514467042 11484 195.159.176.226 (28 Dec 2017 13:17:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Dec 2017 13:17:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29842@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 28 14:17:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY3e-0002WH-WB for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Dec 2017 14:17:15 +0100 Original-Received: from localhost ([::1]:50880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUY5c-0001hR-Qv for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Dec 2017 08:19:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUY5W-0001hB-U6 for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2017 08:19:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUY5N-0005QV-QW for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2017 08:19:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45932) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eUY5N-0005QM-MU for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2017 08:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eUY5N-0005yO-Gk for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2017 08:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Dec 2017 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29842-submit@debbugs.gnu.org id=B29842.151446709522898 (code B ref 29842); Thu, 28 Dec 2017 13:19:01 +0000 Original-Received: (at 29842) by debbugs.gnu.org; 28 Dec 2017 13:18:15 +0000 Original-Received: from localhost ([127.0.0.1]:54612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY4d-0005xG-JF for submit@debbugs.gnu.org; Thu, 28 Dec 2017 08:18:15 -0500 Original-Received: from mail-wr0-f172.google.com ([209.85.128.172]:41253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY4c-0005x2-Db for 29842@debbugs.gnu.org; Thu, 28 Dec 2017 08:18:14 -0500 Original-Received: by mail-wr0-f172.google.com with SMTP id p69so30345453wrb.8 for <29842@debbugs.gnu.org>; Thu, 28 Dec 2017 05:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Km9+g4qAfNv72A6eeOfuxVHDAaykU0qSCb0O9pvmm4E=; b=C3EIsN7tEGyp27/O7BajjJFHgFkH2sLzy+OOliFpEpq6ePfxFQxdwPlqAak+pEeW5x tsQGoe0t2+N1xWAIgUkhSkn4gAo1/4geyb6T4FehjXeT6Y2pvuDdO8gtcKkFqw1rqUUW hqZcZnGo0jgMAXt2wzFwqRRpPwacVXoJTPxsB657ll+HvzrqUcZZ3jRqfl/IWtoHQdtT cWjSUhFBQqOpTOLby/xjFR0osP20/gXn3tQ7EdAq0t/LIA+k69UKgE4+P15zz1rd21oT hnYBW/H42ItrvzDrVs1+UyDxA1PQbE7tF+xBRa3Uf17G6+TLo2RPKXiAMhtN7pYPYklh jtjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Km9+g4qAfNv72A6eeOfuxVHDAaykU0qSCb0O9pvmm4E=; b=GcIVpbg7G73vRnWyiHoecVEi9ezO9+nOq9viZdwXerCCEAVhGxvrRTMjNhnW9HivdN 3OzkCrvYCpYtdjqFZoo/fq/hci2VX7PT9vUoGCiwi+P4sCn+t8M5mnK+oU8wvbp+dffb CwGRmuAGGzU/S2TlfZYm5Dh2QsONYZ4DgW5UQDc0pjf1xNdRZcAGMU/86PAcU0d23dxS SfbU8YW3jq9PAuZjyZb02OS8ErkERIqQyJG0Duls516AxRjVJfPGt3/+ZtlF9QkvYM8o aqyxZcZwyYpmxHRmCl4rLLirQlbehU5B3/IlkByNU1uiJ4PZOhP5pGjeMb4PWuOsIvga Yg/Q== X-Gm-Message-State: AKGB3mKU1k8h3bIHN2XZJR80bv3djAuHT016eaj6jA9bo0xQyopcA9P1 ZyTDIQOYB032ISpjZUXB+BW0kA== X-Google-Smtp-Source: ACJfBouHOvf0C7PeLThbM7WewzeB8HMCI1HJIsmTs/JBa1tZN0RhCakpIIumRo8DumqUoAcDn1Vt6Q== X-Received: by 10.223.148.194 with SMTP id 60mr28004660wrr.39.1514467088619; Thu, 28 Dec 2017 05:18:08 -0800 (PST) Original-Received: from calancha-pc (228.red-83-40-68.dynamicip.rima-tde.net. [83.40.68.228]) by smtp.gmail.com with ESMTPSA id o98sm94485779wrb.40.2017.12.28.05.18.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Dec 2017 05:18:07 -0800 (PST) In-Reply-To: (Drew Adams's message of "Sun, 24 Dec 2017 10:30:54 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141571 Archived-At: Drew Adams writes: > Furthermore, the code should perhaps not just call > `ding' if you hit RET. Instead of this: > > (if (or (eq old ?\r) (eq new ?\r)) > (ding) > ...) > > it should perhaps do something like this: > > (unless (char-displayable-p old) > (error "Not a displayable character: `%c'" old)) > (unless (char-displayable-p new) > (error "Not a displayable character: `%c'" new)) > > The current code predates the existence of > `char-displayable-p'. The more information the better; just a ding force you to read the source code to know what was wrong. Maybe `user-error' instead of `error'?