From: Juri Linkov <juri@linkov.net>
To: Alan Mackenzie <acm@muc.de>
Cc: 30186@debbugs.gnu.org
Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd
Date: Thu, 25 Jan 2018 23:15:41 +0200 [thread overview]
Message-ID: <87vafp7i82.fsf@mail.linkov.net> (raw)
In-Reply-To: <20180125173937.GA3857@ACM> (Alan Mackenzie's message of "Thu, 25 Jan 2018 17:39:38 +0000")
>> Do you agree we could remove the effect of
>> with-silent-modifications around set-text-properties,
>> and leave it only on remove-list-of-text-properties?
>> This will help to fix the reported regression.
>
> I'm not sure about this. Doesn't `set-text-properties' need to be
> "protected", too?
I'm not sure either. Do you think that `set-text-properties' without
`with-silent-modifications' will cause the same problem that you
described in http://lists.gnu.org/r/emacs-devel/2015-04/msg00506.html
> I'm not sure why you want to do this. Why do you want to do this?
Doing yank `C-y' in the minibuffer of `read-passwd' puts dots `.'
over the yanked characters using `display' properties, then later
`set-text-properties' removes all properties (exposing the yanked
characters), but without `with-silent-modifications' it used to put
`display' properties back.
After the change that added `with-silent-modifications',
the hook that puts `display' properties back doesn't run.
> One thing which is puzzling me is that `with-silent-modifications' is a
> macro which is defined in subr.el, but later in the file. Won't this
> invocation of w-s-m get compiled as a function call because of this?
`with-silent-modifications' is a macro that let-binds
`inhibit-modification-hooks' to `t', thus preventing the
hook in `read-passwd' from running.
next prev parent reply other threads:[~2018-01-25 21:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 21:29 bug#30186: 27.0.50; Password is not hidden in read-passwd Juri Linkov
2018-01-21 15:59 ` Eli Zaretskii
2018-01-21 21:19 ` Juri Linkov
2018-01-22 18:27 ` Glenn Morris
2018-01-22 18:45 ` Glenn Morris
2018-01-22 21:38 ` Juri Linkov
2018-01-23 21:38 ` Juri Linkov
2018-01-25 17:39 ` Alan Mackenzie
2018-01-25 21:15 ` Juri Linkov [this message]
2018-01-26 18:37 ` Alan Mackenzie
2018-01-26 19:08 ` Eli Zaretskii
2018-01-26 20:00 ` Alan Mackenzie
2018-01-27 9:40 ` Eli Zaretskii
2018-01-27 11:37 ` Alan Mackenzie
2018-01-27 12:23 ` Eli Zaretskii
2018-01-27 13:38 ` Alan Mackenzie
2018-01-27 21:43 ` Juri Linkov
2018-01-27 22:10 ` Alan Mackenzie
2018-01-27 8:27 ` martin rudalics
2018-01-27 9:21 ` Alan Mackenzie
2018-01-30 8:30 ` martin rudalics
2018-01-22 1:53 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vafp7i82.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30186@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).