From: Noam Postavsky <npostavs@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 30489@debbugs.gnu.org
Subject: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list
Date: Fri, 16 Mar 2018 19:47:18 -0400 [thread overview]
Message-ID: <87vadvvb09.fsf@gmail.com> (raw)
In-Reply-To: <87sha09720.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 16 Feb 2018 17:29:43 +0000")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> @@ -685,7 +685,7 @@ json-readtable-dispatch
> (push (list c 'json-read-number) table))
> (pcase-dolist (`(,c . ,rest) table)
> (push `((eq ,char ,c) (,@rest)) res))
> - `(cond ,@res (t (signal 'json-readtable-error ,char)))))
> + `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
Actually, shouldn't this be (list ,char)?
Otherwise, I get this warning when compiling:
In end of data:
../../lisp/json.el:766:1:Warning: the function ‘char’ is not known to be
defined.
next prev parent reply other threads:[~2018-03-16 23:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:29 bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list Basil L. Contovounesios
2018-03-16 2:39 ` Noam Postavsky
2018-03-16 3:36 ` Eli Zaretskii
2018-03-16 9:52 ` Noam Postavsky
2018-03-16 14:07 ` Eli Zaretskii
2018-03-16 23:47 ` Noam Postavsky [this message]
2018-03-18 0:14 ` Basil L. Contovounesios
2018-03-18 0:25 ` Noam Postavsky
2018-03-18 14:23 ` Basil L. Contovounesios
2018-03-19 3:14 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vadvvb09.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30489@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).