From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Fri, 08 Jun 2018 08:19:45 -0400 Message-ID: <87vaat1ndq.fsf@gmail.com> References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528460292 25919 195.159.176.226 (8 Jun 2018 12:18:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Jun 2018 12:18:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31742@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 08 14:18:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRGLH-0006ZM-0P for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 14:18:07 +0200 Original-Received: from localhost ([::1]:35281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRGNM-0004rs-4w for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 08:20:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRGNC-0004rZ-RL for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 08:20:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRGN9-0006Un-MZ for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 08:20:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRGN9-0006Ug-Ie for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 08:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRGN7-0000EX-Ut for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 08:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jun 2018 12:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31742-submit@debbugs.gnu.org id=B31742.1528460396881 (code B ref 31742); Fri, 08 Jun 2018 12:20:01 +0000 Original-Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 12:19:56 +0000 Original-Received: from localhost ([127.0.0.1]:38881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRGN1-0000E8-O7 for submit@debbugs.gnu.org; Fri, 08 Jun 2018 08:19:55 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:56200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRGN0-0000Dw-3d for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 08:19:54 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id x25-v6so598672ith.5 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 05:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BchMWff3NHRg7Y+446MAZIzYi34tohHOuzWP+ztuRUw=; b=AQb2606zuHzHCBt47K5nr4mez+K7HpdAV5eVN1SVclDh2yP68+PwMPDMGK1J+JWfHt SdL0oZwms0GEw0RH0TMoaq9uPl+pfoYeYEhLF0+Q6IYRyqqYLblNkRM1p2XpGx3HeCGQ ZKD+lmRtdAtQ52qhBMg6hyguP+xOjas0HD8BceKUC8k4cLH3Ijsp8CGuyaUiHp7VHRGf lvJLpAmLxbBb9uTRtS9bTTX/12zhNpKNy6aQwxjCahzUfT2nKbCCEf6J3FtaqLX+GTBg luCgK6MEmXJ/iQGrCkhH+cj7iEelnp+6bV5/E4KgbjT9eJuesijDWMFbMLj2mCtvmRvy 6gog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BchMWff3NHRg7Y+446MAZIzYi34tohHOuzWP+ztuRUw=; b=idMKPdlepUMRApOrtfbho0dA7dwtoCwvfsigAyxd2tzIMDSoQ2qG9VqDRZyqMmRcou px0a7q9ZnzBev7S/7Yg2nWX87VBg7nYPK6FJBXc/FSY6tVKrNWY2bkgG5AibLXQYRrcG lrjbpJVCSbilHdGcOK/bOY/jKapSOptTRU+TaRf71g1Z1CKMtmPJACdzO/KaOgO5xy+N rkBz7zlPADbADIjzNppivulTaxZwVv8j/uvzZynSrlJI2lixz2QOGKyUY/880NvhfNNk pzCAhCqGeesTuoyoIuQI48yft/OmYqxWX5ED5jHR3KIZI0Hnnq5DLRYihtunQ4T/uYTe rMGA== X-Gm-Message-State: APt69E3XaWj2ZluUMFNz2TQdm0orqZg290nde96G0NYUmlsbo2lDCKxw dNEkbeZBbH09xzqjQgrP5a0WXg== X-Google-Smtp-Source: ADUXVKL1KM6uQDg6X7Rz8i+injOZJeGdLgyt/jzRhHdS6A/I2ASqHSptLC7C4J4RpKALhDychC1tpw== X-Received: by 2002:a24:b611:: with SMTP id g17-v6mr1525310itf.63.1528460388384; Fri, 08 Jun 2018 05:19:48 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g26-v6sm1968279iti.0.2018.06.08.05.19.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 05:19:46 -0700 (PDT) In-Reply-To: (Thomas Fitzsimmons's message of "Thu, 07 Jun 2018 22:17:15 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147169 Archived-At: Thomas Fitzsimmons writes: > Noam Postavsky writes: > >> Thomas Fitzsimmons writes: >> >>> (defun soap-resolve-references (element wsdl) >> >>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >> >> Ah, then it should work to replace the (aref element 0) with (type-of >> element) as long as cl-old-struct-compat-mode is enabled. > > Yes, I retested with that change and it does work. I guess I should > submit a patch to change all those occurrences in soap-client. I just noticed soap-client is also an ELPA package; then there is the additional complication that type-of will give the wrong answer in Emacs versions 25 and older. So you would need something like (let ((type (type-of element))) (if (eq type 'vector) (aref element 0) ; For Emacs 25 and earlier. type)) > I'm hoping cl-old-struct-compat-mode will continue to be enabled by > default for a long time. I was going to say, it's currently not enabled by default, but it looks like it gets enabled automagically when you load code from the old cl-defstruct: (defun cl-struct-define (name docstring parent type named slots children-sym tag print) (unless type ;; Legacy defstruct, using tagged vectors. Enable backward compatibility. (cl-old-struct-compat-mode 1))