From: Noam Postavsky <npostavs@gmail.com>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: 31742@debbugs.gnu.org
Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1
Date: Fri, 08 Jun 2018 08:19:45 -0400 [thread overview]
Message-ID: <87vaat1ndq.fsf@gmail.com> (raw)
In-Reply-To: <m3bmcm58es.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Thu, 07 Jun 2018 22:17:15 -0400")
Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
> Noam Postavsky <npostavs@gmail.com> writes:
>
>> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>>
>>> (defun soap-resolve-references (element wsdl)
>>
>>> (let ((resolver (get (aref element 0) 'soap-resolve-references)))
>>
>> Ah, then it should work to replace the (aref element 0) with (type-of
>> element) as long as cl-old-struct-compat-mode is enabled.
>
> Yes, I retested with that change and it does work. I guess I should
> submit a patch to change all those occurrences in soap-client.
I just noticed soap-client is also an ELPA package; then there is the
additional complication that type-of will give the wrong answer in Emacs
versions 25 and older. So you would need something like
(let ((type (type-of element)))
(if (eq type 'vector)
(aref element 0) ; For Emacs 25 and earlier.
type))
> I'm hoping cl-old-struct-compat-mode will continue to be enabled by
> default for a long time.
I was going to say, it's currently not enabled by default, but it looks
like it gets enabled automagically when you load code from the old
cl-defstruct:
(defun cl-struct-define (name docstring parent type named slots children-sym
tag print)
(unless type
;; Legacy defstruct, using tagged vectors. Enable backward compatibility.
(cl-old-struct-compat-mode 1))
next prev parent reply other threads:[~2018-06-08 12:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 1:07 bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Thomas Fitzsimmons
2018-06-07 1:14 ` Noam Postavsky
2018-06-07 2:01 ` Thomas Fitzsimmons
2018-06-07 12:21 ` Noam Postavsky
2018-06-07 14:06 ` Thomas Fitzsimmons
2018-06-07 17:36 ` Noam Postavsky
2018-06-08 1:13 ` Thomas Fitzsimmons
2018-06-08 1:57 ` Noam Postavsky
2018-06-08 2:17 ` Thomas Fitzsimmons
2018-06-08 12:19 ` Noam Postavsky [this message]
2018-06-08 14:18 ` Thomas Fitzsimmons
2018-06-09 0:01 ` Alex Harsanyi
2018-06-09 2:54 ` Thomas Fitzsimmons
2018-06-09 9:13 ` Alex Harsanyi
2018-06-09 10:32 ` Thomas Fitzsimmons
2018-06-12 1:55 ` Thomas Fitzsimmons
2018-06-12 17:11 ` Eli Zaretskii
2018-06-13 1:39 ` Thomas Fitzsimmons
2018-06-17 0:12 ` Alex Harsanyi
2018-06-17 0:36 ` Thomas Fitzsimmons
2018-06-17 1:31 ` Alex Harsanyi
2018-06-17 1:36 ` Noam Postavsky
2018-06-17 13:02 ` Thomas Fitzsimmons
2018-06-09 10:30 ` Thomas Fitzsimmons
2018-06-09 12:13 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaat1ndq.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31742@debbugs.gnu.org \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).