From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#29360: 26.0; Add full-buffer choice for `isearch-lazy-highlight' Date: Fri, 19 Oct 2018 01:18:21 +0300 Organization: LINKOV.NET Message-ID: <87va5yhpaq.fsf@mail.linkov.net> References: <7ec3c778-ee77-48c9-ba10-f21202cac955@default> <87shd8lli4.fsf@mail.linkov.net> <36f5e57c-2eb3-45eb-ae43-3f8fdf7586dd@default> <60f1b355-7455-4bb9-ae3d-294e1494a9d9@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539902359 11200 195.159.176.226 (18 Oct 2018 22:39:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2018 22:39:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 29360@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 19 00:39:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDGwi-0002m6-F6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Oct 2018 00:39:12 +0200 Original-Received: from localhost ([::1]:45079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDGyo-0002CK-VB for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 18:41:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDGyh-0002C1-5W for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 18:41:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDGyZ-00019M-FR for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 18:41:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53241) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDGyU-00016W-UL for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 18:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDGyU-00010m-Na for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 18:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Oct 2018 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29360-submit@debbugs.gnu.org id=B29360.15399024393839 (code B ref 29360); Thu, 18 Oct 2018 22:41:02 +0000 Original-Received: (at 29360) by debbugs.gnu.org; 18 Oct 2018 22:40:39 +0000 Original-Received: from localhost ([127.0.0.1]:57496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDGy7-0000zr-6d for submit@debbugs.gnu.org; Thu, 18 Oct 2018 18:40:39 -0400 Original-Received: from pop.dreamhost.com ([64.90.62.162]:50144 helo=pdx1-sub0-mail-a25.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDGy4-0000zd-T5 for 29360@debbugs.gnu.org; Thu, 18 Oct 2018 18:40:37 -0400 Original-Received: from pdx1-sub0-mail-a25.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a25.g.dreamhost.com (Postfix) with ESMTP id 8BC3B7FFE4; Thu, 18 Oct 2018 15:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=4cTlwTwhpDxYPRXIiZZ708b6qjg=; b= EdGmgiMu2Kb15MxlFvJ8KRWyW4d0FPC2BHJZsW9GkhUxNV5bkCvpnMRXlW4k1Mt3 iKbwik2xPNI9B36A6cLDf3HOMJ4vLuUu4WMSUemR0o7Rlxcam2JF9fh+/Pp+3AIu nplctDxI6X9LBLt1PtQpi1ftBcdu15FpsdSae650xQ0= Original-Received: from mail.jurta.org (m91-129-96-249.cust.tele2.ee [91.129.96.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a25.g.dreamhost.com (Postfix) with ESMTPSA id E04B57FFE6; Thu, 18 Oct 2018 15:40:32 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a25 In-Reply-To: <60f1b355-7455-4bb9-ae3d-294e1494a9d9@default> (Drew Adams's message of "Wed, 17 Oct 2018 22:47:26 -0700 (PDT)") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrfeehgdduhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvgeelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvgeelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughrvgifrdgruggrmhhssehorhgrtghlvgdrtghomhenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151406 Archived-At: > It would really be good if this enhancement were made - for the > reasons I gave in bug #21092, and for other reasons. You asked me > (in bug #21092) to file this bug if I thought we needed such a > full-buffer possibility. This enhancement request was the result. Actually, a full-buffer lazy-highlighting possibility already exists: (setq lazy-highlight-cleanup nil) (add-hook 'isearch-mode-end-hook (lambda () (setq window-group-start-function (lambda (_w) (point-min))) (setq window-group-end-function (lambda (_w _u) (point-max))))) But I agree that more straightforward customization would be better with a clear value of the customizable variable. > Did you not have a patch that took care of this? IIRC you then found > a problem with it wrt `follow-mode', but I thought you had a solution > for that too. (I thought the latter solution was provided by Artur's > `all-windows' value for `isearch-lazy-highlight' etc., which was added.) That patch was installed more than a year ago. > What's the status of this feature? Can we add it to Emacs now? > I hope so. The reason why it's not yet finished is because it was unclear how to integrate it with another similar feature of matches-counting (that counts the number of matches in the full buffer). The reasoning is the following: both features require using the same loop in isearch-lazy-highlight extending it to operate on the full buffer. I know you will argue that these are unrelated features and should be treated separately. But implementation-wise they have only one difference: 1. buffer-matches-highlighting visits all matches and highlights them; 2. buffer-matches-counting visits all matches but doesn't highlight them (only counts) Both need special treatment for possible slowdown in a large buffer, so for performance reasons we need to add a new customizable variable like lazy-buffer-max-at-a-time, separate not to conflict with lazy-highlight-max-at-a-time. The latter applies to the matches on the screen, the former to the matches in the full buffer.