From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Katsumi Yamaoka <yamaoka@jpl.org>, 35233@debbugs.gnu.org
Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 10:57:03 -0700 [thread overview]
Message-ID: <87v9zke87k.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87d0ls32ke.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 17:54:25 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> The recent move to hash-tables[1] introduced the following regression:
>
> 0. HOME=$(mktemp -d) emacs -Q
> 1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j
> 2. M-x gnus RET s M-d
> Wrong number of arguments: #<subr sort>, 1
>
> Passing string-lessp to sort further leads to the following:
>
> 3. Steps 0-2 as above.
> Wrong type argument: vectorp, #s(hash-table ...)
>
> Replacing (intern group gnus-description-hashtb) with just group, and
> repeating steps 0-2 as above, reveals that
> gnus-group-describe-all-groups inserts the group name twice, rather than
> the group name followed by its description. This regression predates
> the move to hash-tables[2].
>
> [1: c1b63af445]: Change Gnus hash tables into real hash tables
> 2019-03-22 10:23:30 -0700
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa
>
> [2: 3982245371]: Sort groups before inserting them into the group buffer
> 2016-02-13 18:45:11 +1100
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25
>
> Patch fixing these to follow.
Ugh, thank you for catching those very stupid mistakes!
next prev parent reply other threads:[~2019-04-11 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:54 bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Basil L. Contovounesios
2019-04-11 16:59 ` Basil L. Contovounesios
2019-04-11 17:57 ` Eric Abrahamsen [this message]
2019-04-11 20:02 ` Basil L. Contovounesios
2019-04-11 20:42 ` Eric Abrahamsen
2019-04-14 1:11 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9zke87k.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=35233@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).