From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34915: 27.0.50; Wdired regression with ls -F Date: Fri, 26 Apr 2019 17:20:30 +0100 Message-ID: <87v9z0g2lt.fsf@tcd.ie> References: <871s33ugi3.fsf@tcd.ie> <87sguncsz9.fsf@gmx.net> <87d0lrcrda.fsf@tcd.ie> <87ftqncr05.fsf@rub.de> <87sgu6f0zp.fsf@gmx.net> <87d0l8hnti.fsf@tcd.ie> <87r29o3g47.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189674"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34915-done@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 26 18:21:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hK3bA-000nFx-Hv for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Apr 2019 18:21:16 +0200 Original-Received: from localhost ([127.0.0.1]:49225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK3b9-0008Sh-HS for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Apr 2019 12:21:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK3b2-0008QI-MV for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:21:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hK3b0-0004uy-M5 for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:21:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48113) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hK3aw-0004qO-Vm for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:21:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hK3aw-0000Fo-MN for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2019 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34915-done@debbugs.gnu.org id=D34915.1556295641908 (code D ref 34915); Fri, 26 Apr 2019 16:21:02 +0000 Original-Received: (at 34915-done) by debbugs.gnu.org; 26 Apr 2019 16:20:41 +0000 Original-Received: from localhost ([127.0.0.1]:33422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK3aZ-0000EX-TR for submit@debbugs.gnu.org; Fri, 26 Apr 2019 12:20:41 -0400 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:41510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK3aX-0000EC-UI for 34915-done@debbugs.gnu.org; Fri, 26 Apr 2019 12:20:38 -0400 Original-Received: by mail-ed1-f54.google.com with SMTP id m4so3635770edd.8 for <34915-done@debbugs.gnu.org>; Fri, 26 Apr 2019 09:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Kr0mOVHCHyQV3G/loRdKrQX1ZgAkqThs4YXPgOgQLP0=; b=t3ZCfKxNNlw/ildLeMuJgb01w98ezh/RiBiakVMY8/gDtgh6IGRwnBeflQuiyYjvVN kOtw1OlTRZj5MKunLThA5GRzRVDqSLFEVnLUOns4CLcdqJynpplGfqFWZVA5opoX9c+l blol2vZZeNkEd47jG79i/Dv8X+aAZUJHIM28JEcaDRmOM/Qh1WYYpVD6pS76Zkl154H2 mChcQCMSvV5g7wGfcgAJmTyjYJNas1YDn3HQCg/H5YEplrgyICMmC2X84EtZpYaEblHo CQWcMwME9wbtxrTY3LTm+s2F3Rh7RafuypS9/tQIOkpVr+iZUsqisyt6jPqQAkixBx3l 2TjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Kr0mOVHCHyQV3G/loRdKrQX1ZgAkqThs4YXPgOgQLP0=; b=gv5xfGuu4dOAgQeaUx2WBtJxR8j2dW6cBkt0iACYKZ5P8Djh3rHgeiTExrukujSbzc WTulKV09sdPcQ4PEeaBB770mL/O5OTclXJ9KqmkFa+1gn1cuBRT885hzTsSMD9mLY2Jz NBZKlIwk+XK96GbfOLU2GAHKrxJyqy6baHdOuUg721SnmL6xZT5I1HEBOcfV4XgskAEP rg5Pd6AA3MgVkMr3uLbbEufTxuG58S/I/GtAbaRD5+27onhHS4v1UOC+cKcmuAVnJrzo D9tQ1/SgWe3TPjWqpoqTAIEKj4mbiYdoBPxh3pKs8Rzr3wo+sqdVqljko6OXhusp5uOw EeTA== X-Gm-Message-State: APjAAAUHxl30ZHp4NMfcsrF01bYMMvv+2XUj2RjcuXGNKVgSdamXRSi6 SLXauY5+t5KLMflPlNOI22GkbA== X-Google-Smtp-Source: APXvYqxxFWUMJblIZ2LBsospfL1T6vp5WL2zOPAIqD0vOXVlCVShBWJTAF3bA3VTPKKL/e+2l2TsUg== X-Received: by 2002:a17:906:d206:: with SMTP id w6mr9592618ejz.248.1556295632038; Fri, 26 Apr 2019 09:20:32 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id l46sm7284353edb.24.2019.04.26.09.20.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Apr 2019 09:20:31 -0700 (PDT) In-Reply-To: <87r29o3g47.fsf@gmx.net> (Stephen Berman's message of "Fri, 26 Apr 2019 18:07:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158301 Archived-At: tags 34915 fixed close 34915 quit Stephen Berman writes: > On Fri, 26 Apr 2019 14:56:57 +0100 "Basil L. Contovounesios" wrote: > >> Thanks. I noticed an opportunity for a tiny bit of reuse: > [...] > > I'm not sure the two uses justify a new function, but I don't oppose > it. I'll leave it for now. >> Which makes me wonder: is there no Dired function that >> wdired--restore-dired-filename-prop can reuse for finding the boundaries >> of a file name? Is dired-move-to-end-of-filename not suitable? It >> seems to perform similar checks for symlinks and --classify. > > dired-move-to-end-of-filename doesn't work in wdired-mode because the > dired-filename text property it uses was removed to fix bug#32173, and > wdired--restore-dired-filename-prop was added to compensate. I couldn't > come up with a more elegant solution. Thanks for explaining and for working on this. Since your patch fixed the bug, I'm closing this report. -- Basil