From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35668: 26.2; default value of `dired-omit-files' Date: Sun, 12 May 2019 12:47:44 -0400 Message-ID: <87v9yfhb67.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="94328"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35668@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 12 18:50:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPrfg-000OLU-Mv for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 18:49:56 +0200 Original-Received: from localhost ([127.0.0.1]:45216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPrff-0008Bl-N8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 12:49:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPrdr-00074f-Nn for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 12:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPrdq-0003sb-RY for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 12:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPrdq-0003rO-KB for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 12:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPrdq-0006A4-Co for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35668 X-GNU-PR-Package: emacs Original-Received: via spool by 35668-submit@debbugs.gnu.org id=B35668.155767967323668 (code B ref 35668); Sun, 12 May 2019 16:48:02 +0000 Original-Received: (at 35668) by debbugs.gnu.org; 12 May 2019 16:47:53 +0000 Original-Received: from localhost ([127.0.0.1]:43201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPrdg-00069g-Uh for submit@debbugs.gnu.org; Sun, 12 May 2019 12:47:53 -0400 Original-Received: from mail-it1-f178.google.com ([209.85.166.178]:34293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPrdf-00069T-Ee for 35668@debbugs.gnu.org; Sun, 12 May 2019 12:47:51 -0400 Original-Received: by mail-it1-f178.google.com with SMTP id p18so11889215itm.1 for <35668@debbugs.gnu.org>; Sun, 12 May 2019 09:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+NLMM6nzxFO9/Ci94JZsI9XOaDofpBN1vxumNMvxP48=; b=WrrDTbVEWdOu6vz82EgqUDLA3cDJ17cz2Dq4evHrmxXNzKIrMV077ZNXW32D5+jn5j JRiloPGufAv52oRNgOdeTCZMK4SXREPhkAymo16Kah2L3jGMGnd2HL4lhR2Fapso/9xm sPolwhrtASSl/1OiyYaT0EvpAO1SH83L6Kr8bDe4LYCC43SPnc21HmxXhF9EW4s7/Ry2 RdPiPZevcy0/8+T9UIlPuLdtWW4y4ghladibm67dhtSCZUB120c0RsIu22KdTqwlrUeA ccm/S/nHUXwt8XdLWt/GHAtO0abKPgr2+knw/RzDcB9+vxBQkdZqh+NQpqILl0WgPM0j zXRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+NLMM6nzxFO9/Ci94JZsI9XOaDofpBN1vxumNMvxP48=; b=Kbg9zzaEfb+6zwkziDX7P9aL+BXpcOz/njdPLTZzo27V1Zz5SxZAjiwCewtemyKeWI neuW6IBYMKBeQvSnGY9+kDvzazpFY1RdqZYt6B1ptqLvZZdQuX7tX7AWlihI4lsaGpwC OWQw+vphhBUrnnboZ10FaZ48RIo4uZQWlWU0o6eQwTPQ2tz9YDRMZjaBu6KWzTsZgT1X +T/IyUCxGqMcauLhJWlSDj7DE4bEztdjvzZe7Td+2iUn5gOgPBeI48aheCOvlfCbFA0z x3Kd6bKa77zMOMrg9a7Bs5/V2NSPyEuyUxnAFS99RKryIb4wAKnEjhNL/aguwNuS211U tIow== X-Gm-Message-State: APjAAAVktV2hfOJ0aHCOg5KQA+8a3r7J6lJ/gupjaYXtQs4Y2XiSKCiq qvuNQ768sTOXN/qyG4Tyu1XCkp1N X-Google-Smtp-Source: APXvYqyd1OCnkXyF8RIDAWuVY6jb11Q7DYgXC1yZG22k6HlHwrta8E7ebGtGapGDG1jYkiXB7gPDOQ== X-Received: by 2002:a05:660c:94e:: with SMTP id h14mr14493760itl.132.1557679665707; Sun, 12 May 2019 09:47:45 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id 1sm5525889ity.9.2019.05.12.09.47.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 May 2019 09:47:44 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Fri, 10 May 2019 06:41:49 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159144 Archived-At: --=-=-= Content-Type: text/plain Drew Adams writes: > As mentioned in passing in bug #34911, I think the default value should > be this: > > "\\`\\.?#\\|\\`\\.\\'\\|\\`\\.\\.\\'" > > instead of this: > > "^\\.?#\\|^\\.$\\|^\\.\\.$" Right, I'd also escape the "." with [], because so many backslashes make my eyes hurt. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-dired-omit-files-regexp-Bug-35668.patch Content-Description: patch >From 1be76f5272236d8238cf8a39ed96732478ea6e39 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 12 May 2019 12:42:35 -0400 Subject: [PATCH] Fix dired-omit-files regexp (Bug#35668) * lisp/dired-x.el (dired-omit-files): Match beginning and of string, rather than beginning of end of line. --- lisp/dired-x.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index defc541ddc..3b78ec47d9 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -159,7 +159,7 @@ (define-minor-mode dired-omit-mode (put 'dired-omit-mode 'safe-local-variable 'booleanp) -(defcustom dired-omit-files "^\\.?#\\|^\\.$\\|^\\.\\.$" +(defcustom dired-omit-files "\\`[.]?#\\|\\`[.][.]?\\'" "Filenames matching this regexp will not be displayed. This only has effect when `dired-omit-mode' is t. See interactive function `dired-omit-mode' (\\[dired-omit-mode]) and variable -- 2.11.0 --=-=-=--