unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: martin rudalics <rudalics@gmx.at>
Cc: 34765@debbugs.gnu.org, alexanderm@web.de, monnier@IRO.UMontreal.CA
Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook
Date: Tue, 21 May 2019 08:58:17 +0100	[thread overview]
Message-ID: <87v9y4p7c6.fsf@tcd.ie> (raw)
In-Reply-To: <5f39dc18-e4d4-dfbc-3bed-18542a10aedb@gmx.at> (martin rudalics's message of "Tue, 21 May 2019 09:32:29 +0200")

martin rudalics <rudalics@gmx.at> writes:

>>> It would be nice to get rid of the entire
>>>
>>>    b->inhibit_buffer_hooks
>>>      = (STRINGP (Vcode_conversion_workbuf_name)
>>>         && strncmp (SSDATA (name), SSDATA (Vcode_conversion_workbuf_name),
>>> 		   SBYTES (Vcode_conversion_workbuf_name)) == 0);
>>>
>>> form in 'get-buffer-create'.  Any ideas?
>>
>> Doesn't your patch in https://debbugs.gnu.org/34765#86 already eliminate
>> the need for it?
>
> FWIW no, it leaves that form in place.

I know, my emphasis was on eliminating the *need* for it.

> And 'get-buffer-create' should not have to worry about delving any
> deeper into the name than down to its first character to check for ' '
> or '*'.
>
> But I'm not happy with my patch anyway.  Something more elegant is
> needed.

The possibilities for the buffer creation subroutine are either to act
specially on certain buffer name prefixes, or to accept an extra
argument indicating what to do, no?  Are there any others?  There was
mention of exposing a buffer-local variable to Elisp, but IIRC setting
that after creating the buffer would already be too late.

Buffer names starting with spaces are already special in some contexts,
so extending that idea for inhibiting buffer hooks doesn't sound too
bad, but the extra flag seems equally elegant and more
backward-compatible.  Am I missing something?

Thanks,

-- 
Basil





  reply	other threads:[~2019-05-21  7:58 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 22:57 bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Alexander Miller
2019-03-06  9:39 ` martin rudalics
2019-03-06 11:29 ` Alexander Miller
2019-03-06 14:13   ` martin rudalics
2019-03-06 15:41     ` Eli Zaretskii
2019-03-06 17:57       ` martin rudalics
2019-04-23  9:21         ` martin rudalics
2019-04-23 10:36           ` Eli Zaretskii
2019-04-24  7:27             ` martin rudalics
2019-04-24 11:12               ` Eli Zaretskii
2019-04-24 12:55                 ` Stefan Monnier
2019-04-25  8:06                 ` martin rudalics
2019-04-25  8:50                   ` Eli Zaretskii
2019-04-25 10:31                     ` martin rudalics
2019-04-25 10:49                       ` Eli Zaretskii
2019-04-26  7:40                         ` martin rudalics
2019-04-26  8:09                           ` Eli Zaretskii
2019-04-25 13:01           ` Stefan Monnier
2019-04-25 14:34             ` Eli Zaretskii
2019-04-26  7:41               ` martin rudalics
2019-04-26  8:10                 ` Eli Zaretskii
2019-04-26  7:41             ` martin rudalics
2019-04-26  8:10               ` Eli Zaretskii
2019-04-26 11:00                 ` martin rudalics
2019-04-26 11:26                   ` Eli Zaretskii
2019-04-27  8:30                     ` martin rudalics
2019-04-26 17:14                   ` Basil L. Contovounesios
2019-04-27  8:31                     ` martin rudalics
2019-05-20 13:42                       ` Basil L. Contovounesios
2019-05-21  7:32                         ` martin rudalics
2019-05-21  7:58                           ` Basil L. Contovounesios [this message]
2019-05-21 10:04                             ` martin rudalics
2019-05-22  7:29                               ` Eli Zaretskii
2019-05-22  8:32                                 ` martin rudalics
2019-05-22 10:06                                   ` Eli Zaretskii
2019-05-23  8:38                                     ` martin rudalics
2019-05-23 14:37                                       ` Eli Zaretskii
2019-05-24  8:01                                         ` martin rudalics
2019-05-22 14:12                                   ` Stefan Monnier
2019-05-22 15:50                                     ` Eli Zaretskii
2019-05-22  7:21                             ` Eli Zaretskii
2020-08-26 11:06                   ` Lars Ingebrigtsen
2020-09-05  7:05                     ` Eli Zaretskii
2020-10-07  3:27                       ` Lars Ingebrigtsen
2020-10-07  7:58                         ` martin rudalics
2020-11-29 21:03                           ` Basil L. Contovounesios
2020-11-30  9:05                             ` martin rudalics
2020-11-30 18:07                               ` Basil L. Contovounesios
2020-11-30 19:01                                 ` martin rudalics
2020-11-30 20:33                                   ` Basil L. Contovounesios
2020-12-01  9:34                                     ` martin rudalics
2020-11-30 19:42                                 ` Eli Zaretskii
2020-11-30 20:34                                   ` Basil L. Contovounesios
2020-12-07 22:16                                     ` Basil L. Contovounesios
2020-12-07 22:37                                       ` Basil L. Contovounesios
2020-12-08  8:09                                         ` martin rudalics
2020-12-14 21:03                                           ` Basil L. Contovounesios
2020-12-15 16:03                                             ` Eli Zaretskii
2020-12-15 16:24                                               ` Basil L. Contovounesios
2020-12-18 14:57                                       ` Basil L. Contovounesios
2020-12-18 15:36                                       ` Stefan Monnier
2020-12-18 18:49                                         ` Basil L. Contovounesios
2020-12-19 10:33                                           ` Eli Zaretskii
2020-12-19 14:15                                             ` Basil L. Contovounesios
2020-12-19 16:06                                               ` Eli Zaretskii
2020-12-19 21:10                                                 ` Basil L. Contovounesios
2020-12-20 15:05                                                   ` Eli Zaretskii
2019-03-07  6:18 ` Alexander Miller
2019-03-07  8:29   ` martin rudalics
2019-03-07  9:44     ` Alexander Miller
2019-03-07 13:46       ` martin rudalics
2020-12-20 17:57 ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9y4p7c6.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=34765@debbugs.gnu.org \
    --cc=alexanderm@web.de \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).