From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33984: 26.1; fortune-compile does not search exec-path for strfile program Date: Wed, 10 Jul 2019 00:32:28 +0200 Message-ID: <87v9waq1oj.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188306"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33984@debbugs.gnu.org To: "Benjamin Ragheb" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 00:33:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkyfh-000mqJ-04 for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 00:33:13 +0200 Original-Received: from localhost ([::1]:56550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkyff-0003Zu-No for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2019 18:33:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32935) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkyfX-0003Yt-VT for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:33:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkyfW-00013w-F2 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkyfW-00011T-1I for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkyfV-0007Ce-Kn for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2019 18:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2019 22:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33984 X-GNU-PR-Package: emacs Original-Received: via spool by 33984-submit@debbugs.gnu.org id=B33984.156271155627411 (code B ref 33984); Tue, 09 Jul 2019 22:33:01 +0000 Original-Received: (at 33984) by debbugs.gnu.org; 9 Jul 2019 22:32:36 +0000 Original-Received: from localhost ([127.0.0.1]:34461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkyf5-00077u-Se for submit@debbugs.gnu.org; Tue, 09 Jul 2019 18:32:36 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkyf3-00075r-KP for 33984@debbugs.gnu.org; Tue, 09 Jul 2019 18:32:34 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkyey-0001ZD-J9; Wed, 10 Jul 2019 00:32:30 +0200 In-Reply-To: (Benjamin Ragheb's message of "Fri, 04 Jan 2019 21:54:28 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162567 Archived-At: "Benjamin Ragheb" writes: > I have attached a patch which corrects this problem by using > executable-find before calling shell-command. If strfile cannot be > found, it signals an error. Makes sense. > I tried to keep the patch as small as possible, and resisted the > temptation to replace the call to shell-command with > call-process. Doing so would have broken compatibility with the > fortune-quiet-strfile-options variable, which people may have > customized. Yeah, that would be better, but would be incompatible as you say. > - (concat fortune-file fortune-database-extension))))) > + (concat fortune-file fortune-database-extension)))) > + (strfile (or (executable-find fortune-strfile) > + (error "Can't find strfile program %s" fortune-strfile))) > (cond ((file-exists-p fortune-file) > (cond ((file-newer-than-file-p fortune-file fortune-dat) > (message "Compiling new fortune database %s" fortune-dat) > (shell-command > - (concat fortune-strfile fortune-strfile-options > + (concat strfile fortune-strfile-options I've now applied this patch to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no