unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 36916@debbugs.gnu.org
Subject: bug#36916: 27.0.50; bug-reference: Make push button action customizable
Date: Sun, 04 Aug 2019 14:03:29 +0200	[thread overview]
Message-ID: <87v9vd3zou.fsf@web.de> (raw)
In-Reply-To: <875zndi40y.fsf@gmx.de> (Michael Albinus's message of "Sun, 04 Aug 2019 13:06:05 +0200")

Michael Albinus <michael.albinus@gmx.de> writes:

> There is the minor mode `debbugs-browse-mode'. Enable it, that's it.

Hmm, ok.  But it's only a minor mode, so instead of having a global
setting, I have to add that minor mode to any place where it's needed.

So, why this does what I want, it's a bit disappointing: bug-reference
hardcodes browse-url, and browse-url can't be changed to handle new
types of urls specially, so the only thing we can do is to hijack
browse-url-browser-function buffer-locally.  Can't this even have side
effects?  What if the Magit revision buffer includes real links?  Oh -
no, I see, that works because the minor mode uses an :before-until
advice.  But it will break if something else binds or sets
browse-url-browser-function, right?

Michael.





  reply	other threads:[~2019-08-04 12:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04  2:30 bug#36916: 27.0.50; bug-reference: Make push button action customizable Michael Heerdegen
2019-08-04 11:06 ` Michael Albinus
2019-08-04 12:03   ` Michael Heerdegen [this message]
2019-08-04 14:49     ` Michael Albinus
2019-08-14 11:24       ` Michael Albinus
2019-08-15 18:14         ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9vd3zou.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=36916@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).