From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 19 Oct 2019 23:53:47 +0300 Organization: LINKOV.NET Message-ID: <87v9sko6k4.fsf@mail.linkov.net> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <87h8476mhz.fsf@mail.linkov.net> <83wod28ryn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250071"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: andreyorst@gmail.com, 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 19 22:55:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLvkl-0012tv-H8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 22:55:11 +0200 Original-Received: from localhost ([::1]:37872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLvkk-0002lZ-A0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 16:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53089) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLvkd-0002jI-13 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 16:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLvkb-0004wa-UM for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 16:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLvkb-0004wT-Qj for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 16:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLvkb-00034b-MT for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 16:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2019 20:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157151848111781 (code B ref 37774); Sat, 19 Oct 2019 20:55:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 19 Oct 2019 20:54:41 +0000 Original-Received: from localhost ([127.0.0.1]:53607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLvkF-00033t-2j for submit@debbugs.gnu.org; Sat, 19 Oct 2019 16:54:41 -0400 Original-Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:13623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLvkB-00033k-Rb for 37774@debbugs.gnu.org; Sat, 19 Oct 2019 16:54:37 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 905EF500D69; Sat, 19 Oct 2019 20:54:34 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a34.g.dreamhost.com (100-96-6-135.trex.outbound.svc.cluster.local [100.96.6.135]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1D65A500C9F; Sat, 19 Oct 2019 20:54:34 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a34.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 19 Oct 2019 20:54:34 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Belong-Cellar: 171e230d1f12b754_1571518474371_1119289579 X-MC-Loop-Signature: 1571518474371:2560533562 X-MC-Ingress-Time: 1571518474371 Original-Received: from pdx1-sub0-mail-a34.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a34.g.dreamhost.com (Postfix) with ESMTP id B89BE8381B; Sat, 19 Oct 2019 13:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=vlgJh5ylYW//RrhbbmN1EpMIP90=; b= thARs4bLnwCVMjnj2Vjj/I2jEoJIJf+NL1CYpYiC6ZQM9D9NUowhWWuULYfoMtKv /CietwmMspE9Y+0d8BUd7L/NSwXIE26S2UM4jvFNG8UzSi6OEzRUS/YD4eFtEz+w MVjAFw1zoN/CVs+yx6g7uStd5ItrkdSOVo5eQTrLjog= Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a34.g.dreamhost.com (Postfix) with ESMTPSA id 0A5FA8381F; Sat, 19 Oct 2019 13:54:25 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a34 In-Reply-To: <83wod28ryn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Oct 2019 09:53:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169757 Archived-At: >> > But I think that our (e)diff blocks are affected by the change and all >> > their face settings probably have to change, as well as tables and >> > listings. >> >> Yes, (e)diff face settings have to change, but actually I discovered >> that diff-refined faces don't need to extend to the window edge, >> because they don't form a block, they are word-based. > > I agree. I think the number of faces that might need to include > :extend is very small. So I added :extend to diff faces, except word-based refinement faces. Also I considered adding :extend to multi-line isearch matches, but in fact yanking in isearch is word-based such as C-w, so maybe the current default is fine. Or do you think it's important to extend highlighting of matched empty lines beyond EOL to make them more noticeable? Then we'll need to extend matching of empty like also for lazy-highlight, hi-lock, occur faces. Additional question: since now in multi-line Info references faces don't extend beyond EOL by default, could the following hack to be removed from info.el: ;; For multiline ref, unfontify newline and surrounding whitespace (save-excursion (goto-char rbeg) (save-match-data (while (re-search-forward "\\s-*\n\\s-*" rend t nil) (remove-text-properties (match-beginning 0) (match-end 0) '(font-lock-face t)))))