From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38216: [PATCH] vc-hg: don't pass empty string to 'update' command Date: Fri, 15 Nov 2019 10:05:27 +0100 Message-ID: <87v9rljyqw.fsf@gnus.org> References: <87bltdlfoj.fsf@gnus.org> <3450b6e8-f9ee-a4b2-a286-bcf250b35892@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="65684"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Andrii Kolomoiets , 38216@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 10:06:45 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVXYz-000GxR-DG for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 10:06:45 +0100 Original-Received: from localhost ([::1]:36854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVXYw-00035b-Hw for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 04:06:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47297) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVXYL-00034c-Lj for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:06:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVXYK-0002Zr-IJ for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:06:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVXYI-0002ZO-4V for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:06:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVXYH-0000yD-SW for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38216 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 38216-submit@debbugs.gnu.org id=B38216.15738087403702 (code B ref 38216); Fri, 15 Nov 2019 09:06:01 +0000 Original-Received: (at 38216) by debbugs.gnu.org; 15 Nov 2019 09:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:35652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVXXw-0000xe-Bg for submit@debbugs.gnu.org; Fri, 15 Nov 2019 04:05:40 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:40050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVXXu-0000xN-2Q for 38216@debbugs.gnu.org; Fri, 15 Nov 2019 04:05:39 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iVXXk-0004KS-Nc; Fri, 15 Nov 2019 10:05:31 +0100 In-Reply-To: <3450b6e8-f9ee-a4b2-a286-bcf250b35892@gmx.at> (martin rudalics's message of "Fri, 15 Nov 2019 09:59:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171653 Archived-At: martin rudalics writes: >> Thanks; applied the patch to Emacs 27. > > Gets me > > ../../lisp/vc/vc-hg.el:1467:1:Warning: the function `string-empty-p' is not > known to be defined. > > here. Huh; my patch applying function is supposed to do a byte compilation to catch bugs like that... but I must have forgotten to actually look at it. I've now changed it to avoid this subr-x function. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no