From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17272: bug#19064: bug#17272: bug#19064: bug#17272: bug#19064: 25.0.50; `message' overwrites `y-or-n-p' prompt, so user misses it Date: Thu, 21 Nov 2019 00:10:59 +0200 Organization: LINKOV.NET Message-ID: <87v9reqk6o.fsf@mail.linkov.net> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <875zjx6hs6.fsf@mail.linkov.net> <87sgmy3x22.fsf@gnus.org> <871rugbqmy.fsf@mail.linkov.net> <87d0dxyh7z.fsf@gnus.org> <53c55db5-d623-4946-af2e-d141e7bc7acd@default> <87sgmrpir5.fsf@web.de> <87mucya2a7.fsf@web.de> <87mucy4cb2.fsf@web.de> <621b98dc-0fe9-4eef-9e11-7580fb446e97@default> <87k1822ocn.fsf@web.de> <87lfsfmtk0.fsf@mail.linkov.net> <874kz3gibu.fsf@gnus.org> <87bltaw3xz.fsf@mail.linkov.net> <87r224x54p.fsf@mail.linkov.net> <87v9rgnv0o.fsf@gnus.org> <877e3vqx9r.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112660"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Michael Heerdegen , 17272@debbugs.gnu.org, Lars Ingebrigtsen , 19064@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 20 23:48:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXYly-000Sxd-KZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 23:48:30 +0100 Original-Received: from localhost ([::1]:34858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXYlr-0001CK-Lj for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 17:48:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47810) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXYlZ-0001Bq-OH for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 17:48:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXYlX-0006ST-JD for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 17:48:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXYlW-0006S3-OS for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 17:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXYlW-00062i-Iu for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 17:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2019 22:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 17272-submit@debbugs.gnu.org id=B17272.157429004923116 (code B ref 17272); Wed, 20 Nov 2019 22:48:02 +0000 Original-Received: (at 17272) by debbugs.gnu.org; 20 Nov 2019 22:47:29 +0000 Original-Received: from localhost ([127.0.0.1]:51024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXYky-00060k-Qw for submit@debbugs.gnu.org; Wed, 20 Nov 2019 17:47:29 -0500 Original-Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:56790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXYkl-000606-D3; Wed, 20 Nov 2019 17:47:16 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 13640500A49; Wed, 20 Nov 2019 22:47:14 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-196-51.trex.outbound.svc.cluster.local [100.96.196.51]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 65E5C5017E9; Wed, 20 Nov 2019 22:47:13 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 20 Nov 2019 22:47:13 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cold-Arch: 1e1de25726b7608f_1574290033732_3596591818 X-MC-Loop-Signature: 1574290033732:3942751158 X-MC-Ingress-Time: 1574290033731 Original-Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id 7A80A832D8; Wed, 20 Nov 2019 14:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=ZBgPWiF1HKiypXCpAA67/XSBAQM=; b= cDxIQhFW70GwK2k5f7cuJiqaBHDFKj5o22F0qVdFnXIHrLGeGbc2mD1CQBzTLEtz GoNR5YIbTNu/sUzysY4gu7Zrq36qzYaYdXFkX/lIwBFSv3Ixz3W/zNWxYJEjVsA+ bcSSJUUL/Ge3LLJ9AXCSsKLIvAxS/J+UUz1AEhW+aUM= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id 4A538832D4; Wed, 20 Nov 2019 14:47:00 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 19 Nov 2019 23:38:20 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172076 Archived-At: > Emacs -Q > M-x fido-mode > (defalias 'yes-or-no-p 'y-or-n-p) ;; a common custmization > C-x b > C-k ;; to kill the Messages buffer > > Before your changes to `y-or-n-p` this worked well, afterwards > I get the "Attempt to use minibuffer inside minibuffer" error. > > Bear in mind that fido-mode is very new. Also bear in mind > that the problem is already present when yes-or-no-p is used. > > I think a good fix is for icomplete to do this (and for > you to do nothing :-) ) It's tempting to do nothing :-), but since the problem is already present with yes-or-no-p too, it should be fixed because it's a general problem affecting other commands too. The nil value of enable-recursive-minibuffers by default was intended to avoid confusion for beginners unadvisedly typing such sequences as M-x M-x M-x M-x M-x ... to get out from which is not easy. But for yes/no or y/n questions it should be right to allow recursive minibuffers temporarily: diff --git a/lisp/subr.el b/lisp/subr.el index 20daed623f..2265965c60 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -2847,6 +2848,7 @@ y-or-n-p (t (setq prompt (funcall padded prompt)) (let* ((empty-history '()) + (enable-recursive-minibuffers t) (str (read-from-minibuffer prompt nil (make-composed-keymap y-or-n-p-map query-replace-map) diff --git a/src/fns.c b/src/fns.c index cbb6879223..3ae3192b3d 100644 --- a/src/fns.c +++ b/src/fns.c @@ -2805,15 +2805,18 @@ DEFUN ("yes-or-no-p", Fyes_or_no_p, Syes_or_no_p, 1, 1, 0, AUTO_STRING (yes_or_no, "(yes or no) "); prompt = CALLN (Fconcat, prompt, yes_or_no); + ptrdiff_t count = SPECPDL_INDEX (); + specbind (Qenable_recursive_minibuffers, Qt); + while (1) { ans = Fdowncase (Fread_from_minibuffer (prompt, Qnil, Qnil, Qnil, Qyes_or_no_p_history, Qnil, Qnil)); if (SCHARS (ans) == 3 && !strcmp (SSDATA (ans), "yes")) - return Qt; + return unbind_to (count, Qt); if (SCHARS (ans) == 2 && !strcmp (SSDATA (ans), "no")) - return Qnil; + return unbind_to (count, Qnil); Fding (Qnil); Fdiscard_input ();