unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region'
@ 2020-01-07 16:19 Alexander Shukaev
  2020-01-20  0:27 ` Juri Linkov
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shukaev @ 2020-01-07 16:19 UTC (permalink / raw)
  To: 39015

Not sure why in the first place `isearch-complete1' uses some custom 
auto-completion implementation that is different from a conventional 
solution, perhaps historical reasons.  Thus, I believe that reusing 
either `completion-at-point' or `completion-in-region' to implement that 
functionality is much better in the long run.  This would also allow 
packages, which customize completion behavior, to hook into `isearch' 
auto-completion as well.  See also [1] for example.

[1] https://github.com/abo-abo/swiper/issues/1882





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region'
  2020-01-07 16:19 bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region' Alexander Shukaev
@ 2020-01-20  0:27 ` Juri Linkov
  0 siblings, 0 replies; 2+ messages in thread
From: Juri Linkov @ 2020-01-20  0:27 UTC (permalink / raw)
  To: Alexander Shukaev; +Cc: 39015

> Not sure why in the first place `isearch-complete1' uses some custom
> auto-completion implementation that is different from a conventional
> solution, perhaps historical reasons.  Thus, I believe that reusing either
> `completion-at-point' or `completion-in-region' to implement that
> functionality is much better in the long run.  This would also allow
> packages, which customize completion behavior, to hook into `isearch'
> auto-completion as well.  See also [1] for example.
>
> [1] https://github.com/abo-abo/swiper/issues/1882

Based on this solution
https://lists.gnu.org/archive/html/emacs-devel/2020-01/msg00447.html
it should be possible to write a patch that would hook into `isearch'
auto-completion.  I seems I can't do this since I don't understand
how to test it.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-20  0:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-07 16:19 bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region' Alexander Shukaev
2020-01-20  0:27 ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).