From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#31800: suggestion of improvement for sort-numeric-fields function. Date: Mon, 20 Jan 2020 20:55:04 +0100 Message-ID: <87v9p5rjhj.fsf@marxist.se> References: <874l3qy517.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="2682"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 31800@debbugs.gnu.org To: SK Kim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 20 20:56:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itd9m-0000U6-6Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 20:56:18 +0100 Original-Received: from localhost ([::1]:43610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itd9l-00052Z-5X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 14:56:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39086) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itd9Z-00052J-Rt for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:56:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itd9V-0007n5-Un for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:56:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40143) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itd9V-0007my-Mk for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:56:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itd9V-0001kV-Jp for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31800-submit@debbugs.gnu.org id=B31800.15795501156651 (code B ref 31800); Mon, 20 Jan 2020 19:56:01 +0000 Original-Received: (at 31800) by debbugs.gnu.org; 20 Jan 2020 19:55:15 +0000 Original-Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itd8k-0001jD-Ne for submit@debbugs.gnu.org; Mon, 20 Jan 2020 14:55:14 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:41356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itd8h-0001ip-PX for 31800@debbugs.gnu.org; Mon, 20 Jan 2020 14:55:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gTKdlg+7b7ETxNW9yFpZVPfLW7ye9p9XiIjy2vHGk+g=; b=fwDRvjgMgwxxDOJ63ch94Nsd07 NkpXbEi9OXLmMAyEIyqJ1iaZaw4k5vMEqJbdRXO27jbofX+3I3Axjd0OrRbyrCTxyP+fDH98+8ixr qnXb5x7OIGpJGKMsljKuNC8FTPigRFJnXonaRzUN3eCLiCAd3KqY51gpVWfKsnnlPi4gEvsNhIICA rUA+gYAgvP2Ho65nlHeCckoGJZHG/tS7F3jtbpqSZ/oeBswWdk+jw3OtEP6XUJwZU8DqpFIYRAH9d lEIp1zWk6gVaq5Hlrqy1tu1YkEpMrG+usq9h5XuweXvB8azCajsEdpqRp7qDhSfvR72JxYEJeffxx mk2kze3A==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:43124 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itd8b-0006We-Rc; Mon, 20 Jan 2020 14:55:06 -0500 In-Reply-To: (SK Kim's message of "Sat, 13 Jul 2019 17:21:18 +0900") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174953 Archived-At: SK Kim writes: > I made this patch from github emacs-mirror repository. > I hope this will be of help. > > Thanks. > > 2019=EB=85=84 7=EC=9B=94 13=EC=9D=BC (=ED=86=A0) =EC=98=A4=ED=9B=84 12:42= , Lars Ingebrigtsen =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > SK Kim writes: > > > This is not likely a bug but sort-numeric-fields function does not > > allow region with blank lines, while sort-lines does. > > > > This was because sort-skip-fields occurs error with blank line. And > > when I added condition for sort-skip-fields like below, > > sort-numeric-fields was working with blank lines too. > > > > (when (not (string-match-p "^\\s-*$" (thing-at-po= int 'line))) > > (sort-skip-fields field)) > > > > So, I just hope sort-numeric-fields would work for region with blank > > lines too. The patch below looks good to me. Does anyone else have an opinion here, or should I go ahead and commit it to master? Best regards, Stefan Kangas > From d08c5d368337ee49bb72d9915c409edcbc73b4e0 Mon Sep 17 00:00:00 2001 > From: SeungKi Kim > Date: Sat, 13 Jul 2019 17:12:46 +0900 > Subject: [PATCH] Improve `sort-numeric-fields' > > * lisp/sort.el (sort-numeric-fields) : Allow including empty lines. > --- > lisp/sort.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/sort.el b/lisp/sort.el > index 6ea1c44060..3e9413e4af 100644 > --- a/lisp/sort.el > +++ b/lisp/sort.el > @@ -281,7 +281,8 @@ FIELD, BEG and END. BEG and END specify region to so= rt." > ((inhibit-field-text-motion t)) > (sort-fields-1 field beg end > (lambda () > - (sort-skip-fields field) > + (unless (string-match-p "^\\s-*$" (thing-at-point '= line)) > + (sort-skip-fields field)) > (let* ((case-fold-search t) > (base > (if (looking-at "\\(0x\\)[0-9a-f]\\|\\(0\\)[0-7]")