From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41723: 26.3; Enable replying to an ical event even when not an attendee Date: Fri, 05 Jun 2020 18:58:48 +0100 Message-ID: <87v9k5cs2v.fsf@tcd.ie> References: <87k10lld4p.fsf@poincare.umons.ac.be> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41723@debbugs.gnu.org To: Christophe Troestler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 05 20:08:47 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhGlr-000W5D-2u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 20:08:47 +0200 Original-Received: from localhost ([::1]:59568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhGlq-0001bF-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 14:08:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhGdP-00079E-2h for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:00:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhGdO-0000jm-OS for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhGdO-0004Ef-LP for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2020 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41723 X-GNU-PR-Package: emacs Original-Received: via spool by 41723-submit@debbugs.gnu.org id=B41723.159137994316169 (code B ref 41723); Fri, 05 Jun 2020 18:00:02 +0000 Original-Received: (at 41723) by debbugs.gnu.org; 5 Jun 2020 17:59:03 +0000 Original-Received: from localhost ([127.0.0.1]:49865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhGcM-0004CL-40 for submit@debbugs.gnu.org; Fri, 05 Jun 2020 13:59:03 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:53924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhGcK-0004Bw-Tw for 41723@debbugs.gnu.org; Fri, 05 Jun 2020 13:58:57 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id l26so9212249wme.3 for <41723@debbugs.gnu.org>; Fri, 05 Jun 2020 10:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EQEDd71k965FO6DxgIKFHNM7LBFbJJcpWPz4WjK2qao=; b=b0wzbrs/MPLTLG8GJWoi/5AgPIKB3jWqJacCoVE78o6nJw1UGaKrs0zQEcPLSK3ZBp nBgtKAHTrZj2StllvKQgBzuxyqjq8jdquV4N/lpTI6kLB2ZXqiQfYezJqe7XXbAHKxmL C4u310L0EUq9WjZYKcgVuPu9DEONpF656sDi+K+000GFwyrLo41nqPE8crSbTOHQBWcC 3QE6tvSTzXmFIL69Af8JIIIgRRULD3eCnoumGEzope3XU4U6Rn/eTia+mcpaGssS4Hws y6j0hmN8yeG3gcVzKgHNd39wDIFugzJuWv9+YABu3iFj0dfxZajieWtLsnuWOZx6XFRQ X21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EQEDd71k965FO6DxgIKFHNM7LBFbJJcpWPz4WjK2qao=; b=FIAooOwCDJjadPGoQQuvjYXsnOfxAvdnv/0MOH5GCjyoUxhQ6+uyZ8ksF/4Lo+qae6 ZxSQPFx9ZTmsO/3y9JVJ4v1O3SWvfNWmkqYBB63gGYO/0DPBvSzVVKhrkOJnM+Fid+IV OHbI2+1DklgTl4ZXhC8m57m/bADoE6rHew8VEMSAJ4LHaxrI5+XXxxX1RO0xnm3WZEfS W0eAWbJ+/MTxxElQ3odpLKOk1NDaJlFYXSeXUy2tcWrMkDLLS3aKvmWjIrMDEbIQTUIm bEAVAEv4Ird3okk00cbgSrXkMzM4zXKPldPVbyOn3qQ8wqaFqenHuMj11j5VWHIBldgL 2zsg== X-Gm-Message-State: AOAM532Gg3Djs42WBIamD0OlypD+rpuiuysj90mfNFG7KN/vYaGipUU8 zM19vrztfEK7q68hyDsBGHgyZQ== X-Google-Smtp-Source: ABdhPJzeFLNQtOcaAj3Yb4w5Nh+GEdsDS3K01F81NFLKW3N8gKgeCgvYF2FCLcDPMqqMI0t9Fn4Isg== X-Received: by 2002:a1c:4d14:: with SMTP id o20mr3687632wmh.164.1591379930460; Fri, 05 Jun 2020 10:58:50 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id r4sm12875600wro.32.2020.06.05.10.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 10:58:49 -0700 (PDT) In-Reply-To: <87k10lld4p.fsf@poincare.umons.ac.be> (Christophe Troestler's message of "Fri, 05 Jun 2020 17:56:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181577 Archived-At: reassign 41723 gnus,emacs tags 41723 + patch quit Christophe Troestler writes: > When one receives en ical event and the user identity is not present in the > attendee list, an error is triggered making replying to such an event impossible > (the reply message not being even composed). This patch replaces it with a > warning. This is necessary because one may receive (I just did) events that the > organizer did not set up well and it is up to the user (not Emacs) to decide > whether or not to reply to them. Thanks. Sounds fine to me, but I'm not familiar with this part of Gnus, so I can only offer a couple of nitpicks. > From a7c5289908d40b54e0c474b970d3f3786bc941af Mon Sep 17 00:00:00 2001 > From: Christophe Troestler > Date: Fri, 5 Jun 2020 17:35:48 +0200 > Subject: [PATCH] Enable replying to an ical event even when not an attendee > Content-Type: text/plain; charset="utf-8" > > When the user identity is not present in the attendee list, an error > is triggered making replying to such an event impossible (the reply > message not being even composed). This replaces it with a warning. > This is necessary because one may receive events that the organizer > did not set up well and it is up to the user to decide whether or not > to reply to them. The commit message conventions followed by Emacs are described in the file CONTRIBUTE and also under (info "(emacs) Format of ChangeLog"). It's fine to include the free-standing prose, but the commit message should also mention the file and definition being changed, e.g.: * lisp/gnus/gnus-icalendar.el (gnus-icalendar-event--build-reply-event-body): Display a warning instead of barfing when user is missing from attendee list. > diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el > index 305e17fd8f..f7b9a954d6 100644 > --- a/lisp/gnus/gnus-icalendar.el > +++ b/lisp/gnus/gnus-icalendar.el > @@ -312,7 +312,8 @@ gnus-icalendar-event--build-reply-event-body > > (unless (gnus-icalendar-find-if (lambda (x) (string-match "^ATTENDEE" x)) > reply-event-lines) > - (error "Could not find an event attendee matching given identity")) > + (lwarn 'gnus :warning ^^^^^ Why not 'gnus-icalendar instead? > + "Could not find an event attendee matching given identity")) -- Basil